You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/08/22 00:21:13 UTC

[kudu-CR] KUDU-428: Sentry integration scaffolding 

Hello Adar Dembo, Hao Hao,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/11292

to review the following change.


Change subject: KUDU-428: Sentry integration scaffolding
......................................................................

KUDU-428: Sentry integration scaffolding

In preparation for KUDU-428 (Sentry integration), this commit introduces
some basic module and build-system scaffolding, including a new 'sentry'
module, as well as the Sentry service thrift definition files. This is
heavily based on the HMS integration equivalents.

Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
---
M CMakeLists.txt
M cmake_modules/FindThrift.cmake
M src/kudu/hms/CMakeLists.txt
A src/kudu/sentry/CMakeLists.txt
A src/kudu/sentry/mini_sentry.cc
A src/kudu/sentry/mini_sentry.h
A src/kudu/sentry/sentry_client-test.cc
A src/kudu/sentry/sentry_client.cc
A src/kudu/sentry/sentry_client.h
A src/kudu/sentry/sentry_common_service.thrift
A src/kudu/sentry/sentry_policy_service.thrift
A src/kudu/sentry/thrift_operators.cc
12 files changed, 668 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/11292/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11292

to look at the new patch set (#3).

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................

KUDU-428: Sentry integration scaffolding

In preparation for KUDU-428 (Sentry integration), this commit introduces
some basic module and build-system scaffolding, including a new 'sentry'
module, as well as the Sentry service thrift definition files. This is
heavily based on the HMS integration equivalents.

Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
---
M CMakeLists.txt
M cmake_modules/FindThrift.cmake
M src/kudu/hms/CMakeLists.txt
A src/kudu/sentry/CMakeLists.txt
A src/kudu/sentry/mini_sentry.cc
A src/kudu/sentry/mini_sentry.h
A src/kudu/sentry/sentry_client-test.cc
A src/kudu/sentry/sentry_client.cc
A src/kudu/sentry/sentry_client.h
A src/kudu/sentry/sentry_common_service.thrift
A src/kudu/sentry/sentry_policy_service.thrift
A src/kudu/sentry/thrift_operators.cc
12 files changed, 684 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/11292/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11292

to look at the new patch set (#2).

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................

KUDU-428: Sentry integration scaffolding

In preparation for KUDU-428 (Sentry integration), this commit introduces
some basic module and build-system scaffolding, including a new 'sentry'
module, as well as the Sentry service thrift definition files. This is
heavily based on the HMS integration equivalents.

Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
---
M CMakeLists.txt
M cmake_modules/FindThrift.cmake
M src/kudu/hms/CMakeLists.txt
A src/kudu/sentry/CMakeLists.txt
A src/kudu/sentry/mini_sentry.cc
A src/kudu/sentry/mini_sentry.h
A src/kudu/sentry/sentry_client-test.cc
A src/kudu/sentry/sentry_client.cc
A src/kudu/sentry/sentry_client.h
A src/kudu/sentry/sentry_common_service.thrift
A src/kudu/sentry/sentry_policy_service.thrift
A src/kudu/sentry/thrift_operators.cc
12 files changed, 680 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/11292/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11292 )

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................


Patch Set 2:

I'm still iterating on a design doc which lays out a bigger plan for KUDU-428, but I wanted to get this up early because it took a long time to land the corresponding change during the HMS integration, and it's a good jumping off point for parallelizing the implementation work.  So, it's fine by me if we hold off merging until after the design doc has had a chance to bake.


-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 22 Aug 2018 02:30:26 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11292

to look at the new patch set (#6).

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................

KUDU-428: Sentry integration scaffolding

In preparation for KUDU-428 (Sentry integration), this commit introduces
some basic module and build-system scaffolding, including a new 'sentry'
module, as well as the Sentry service thrift definition files. This is
heavily based on the HMS integration equivalents.

Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
---
M CMakeLists.txt
M cmake_modules/FindThrift.cmake
M src/kudu/hms/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
A src/kudu/sentry/CMakeLists.txt
A src/kudu/sentry/mini_sentry.cc
A src/kudu/sentry/mini_sentry.h
A src/kudu/sentry/sentry_client-test.cc
A src/kudu/sentry/sentry_client.cc
A src/kudu/sentry/sentry_client.h
A src/kudu/sentry/sentry_common_service.thrift
A src/kudu/sentry/sentry_policy_service.thrift
A src/kudu/sentry/thrift_operators.cc
13 files changed, 694 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/11292/6
-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11292 )

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................


Patch Set 6:

The design doc has been published [1].  There are some open questions remaining, but none of those should effect the need for this scaffolding, so I think it's ready to merge.

[1]: https://docs.google.com/document/d/1SEBtgWwBFqij5CuCZwhOqDNSDVViC0WERq6RzsPCWjQ/edit?usp=sharing


-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Aug 2018 22:45:18 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11292 )

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 7
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Aug 2018 23:12:04 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11292 )

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................


Patch Set 7:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/CMakeLists.txt
File src/kudu/sentry/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/CMakeLists.txt@17
PS6, Line 17: 
> Nit: could you add ### headers for sentry_thrift and kudu_sentry?
Done, also added to hms for consistency.


http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/CMakeLists.txt@29
PS6, Line 29: 
> Sort order here.
Done


http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/sentry_client-test.cc
File src/kudu/sentry/sentry_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/sentry_client-test.cc@33
PS6, Line 33: TEST_F(SentryClientTest, ItWorks) {
            :   SentryClient client;
            :   std::move(client);
            : }
> Nice.
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 7
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Aug 2018 23:10:14 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11292

to look at the new patch set (#5).

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................

KUDU-428: Sentry integration scaffolding

In preparation for KUDU-428 (Sentry integration), this commit introduces
some basic module and build-system scaffolding, including a new 'sentry'
module, as well as the Sentry service thrift definition files. This is
heavily based on the HMS integration equivalents.

Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
---
M CMakeLists.txt
M cmake_modules/FindThrift.cmake
M src/kudu/hms/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
A src/kudu/sentry/CMakeLists.txt
A src/kudu/sentry/mini_sentry.cc
A src/kudu/sentry/mini_sentry.h
A src/kudu/sentry/sentry_client-test.cc
A src/kudu/sentry/sentry_client.cc
A src/kudu/sentry/sentry_client.h
A src/kudu/sentry/sentry_common_service.thrift
A src/kudu/sentry/sentry_policy_service.thrift
A src/kudu/sentry/thrift_operators.cc
13 files changed, 695 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/11292/5
-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 5
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11292 )

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................

KUDU-428: Sentry integration scaffolding

In preparation for KUDU-428 (Sentry integration), this commit introduces
some basic module and build-system scaffolding, including a new 'sentry'
module, as well as the Sentry service thrift definition files. This is
heavily based on the HMS integration equivalents.

Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Reviewed-on: http://gerrit.cloudera.org:8080/11292
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
M cmake_modules/FindThrift.cmake
M src/kudu/hms/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
A src/kudu/sentry/CMakeLists.txt
A src/kudu/sentry/mini_sentry.cc
A src/kudu/sentry/mini_sentry.h
A src/kudu/sentry/sentry_client-test.cc
A src/kudu/sentry/sentry_client.cc
A src/kudu/sentry/sentry_client.h
A src/kudu/sentry/sentry_common_service.thrift
A src/kudu/sentry/sentry_policy_service.thrift
A src/kudu/sentry/thrift_operators.cc
13 files changed, 717 insertions(+), 8 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 8
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11292

to look at the new patch set (#4).

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................

KUDU-428: Sentry integration scaffolding

In preparation for KUDU-428 (Sentry integration), this commit introduces
some basic module and build-system scaffolding, including a new 'sentry'
module, as well as the Sentry service thrift definition files. This is
heavily based on the HMS integration equivalents.

Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
---
M CMakeLists.txt
M cmake_modules/FindThrift.cmake
M src/kudu/hms/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
A src/kudu/sentry/CMakeLists.txt
A src/kudu/sentry/mini_sentry.cc
A src/kudu/sentry/mini_sentry.h
A src/kudu/sentry/sentry_client-test.cc
A src/kudu/sentry/sentry_client.cc
A src/kudu/sentry/sentry_client.h
A src/kudu/sentry/sentry_common_service.thrift
A src/kudu/sentry/sentry_policy_service.thrift
A src/kudu/sentry/thrift_operators.cc
13 files changed, 692 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/11292/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 4
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11292 )

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/CMakeLists.txt
File src/kudu/sentry/CMakeLists.txt:

http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/CMakeLists.txt@17
PS6, Line 17: 
Nit: could you add ### headers for sentry_thrift and kudu_sentry?


http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/CMakeLists.txt@29
PS6, Line 29:   sentry_thrift
Sort order here.


http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/sentry_client-test.cc
File src/kudu/sentry/sentry_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/11292/6/src/kudu/sentry/sentry_client-test.cc@33
PS6, Line 33: TEST_F(SentryClientTest, ItWorks) {
            :   SentryClient client;
            :   std::move(client);
            : }
Nice.



-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Aug 2018 22:56:27 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-428: Sentry integration scaffolding

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11292

to look at the new patch set (#7).

Change subject: KUDU-428: Sentry integration scaffolding
......................................................................

KUDU-428: Sentry integration scaffolding

In preparation for KUDU-428 (Sentry integration), this commit introduces
some basic module and build-system scaffolding, including a new 'sentry'
module, as well as the Sentry service thrift definition files. This is
heavily based on the HMS integration equivalents.

Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
---
M CMakeLists.txt
M cmake_modules/FindThrift.cmake
M src/kudu/hms/CMakeLists.txt
M src/kudu/mini-cluster/CMakeLists.txt
A src/kudu/sentry/CMakeLists.txt
A src/kudu/sentry/mini_sentry.cc
A src/kudu/sentry/mini_sentry.h
A src/kudu/sentry/sentry_client-test.cc
A src/kudu/sentry/sentry_client.cc
A src/kudu/sentry/sentry_client.h
A src/kudu/sentry/sentry_common_service.thrift
A src/kudu/sentry/sentry_policy_service.thrift
A src/kudu/sentry/thrift_operators.cc
13 files changed, 717 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/11292/7
-- 
To view, visit http://gerrit.cloudera.org:8080/11292
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51e68299b97f74f6844bfa9f8aba4c0bd4246c11
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 7
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins