You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/01/19 22:26:04 UTC
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1523
[FLINK-3161][dist] Externalize cluster start-up and tear-down when available
Parallelizes cluster start-up and tear-down when pdsh is available
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3161_externalize_cluster_startup_and_teardown_when_available
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1523.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1523
----
commit eb2594f4269e47225cf69d441ef0d138627a5db4
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-01-15T21:16:34Z
[FLINK-3161][dist] Externalize cluster start-up and tear-down when available
Parallelizes cluster start-up and tear-down when pdsh is available
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-179464861
Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-176858076
New commit which passes FLINK_SSH_OPTS to pdsh.
Also, some sample timings starting and stopping an AWS cluster of various sizes, with ssh and pdsh comparable on a single node and pdsh noticeably faster on large clusters.
64 x c4.large | ssh | pdsh
------------- | --- | ----
start | 13.969s | 4.210s
stop | 12.533s | 4.181s
start | 13.906s | 4.203s
stop | 13.169s | 4.283s
start | 14.122s | 4.262s
stop | 12.343s | 4.196s
16 x c4.large | ssh | pdsh
------------- | --- | ----
start | 3.961s | 1.270s
stop | 2.985s | 1.267s
start | 3.638s | 1.277s
stop | 3.014s | 1.164s
start | 3.410s | 1.470s
stop | 3.159s | 1.180s
1 x c4.large | ssh | pdsh
------------- | --- | ----
start | 0.439s | 0.543s
stop | 1.247s | 0.449s
start | 0.448s | 0.547s
stop | 1.439s | 1.300s
start | 0.439s | 0.542s
stop | 0.827s | 0.452s
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-179308417
Hi @greghogan, thanks for the update!
Looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1523
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-174540358
I'm not familiar with `pdsh` but is there a way to pass the `FLINK_SSH_OPTS` on?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-173217454
Seems that `pdsh` is available in all Ubuntu versions. So I guess the tool is popular enough to be present for some of our users.
I think some tests on a cluster would be valuable to make sure we didn't oversee anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-172993085
I haven't had access to a cluster in a few days but if needed or if this is still open I'll post timings next time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-175671773
The `pdsh` section on [Environment Variables](http://linux.die.net/man/1/pdsh) lists two options:
> PDSH_SSH_ARGS
> Override the standard arguments that pdsh passes to the ssh(1) command ("-2 -a -x -l%u %h"). The use of the parameters %u, %h, and %n (as documented in the rcmd/exec section above) is optional. If these parameters are missing, pdsh will append them to the ssh commandline because it is assumed they are mandatory.
> PDSH_SSH_ARGS_APPEND
> Append additional options to the ssh(1) command invoked by pdsh. For example, PDSH_SSH_ARGS_APPEND="-q" would run ssh in quiet mode, or "-v" would increase the verbosity of ssh. (Note: these arguments are actually prepended to the ssh commandline to ensure they appear before any target hostname argument to ssh.)
By default `pdsh` is enforcing protocol version 2, disabling the authentication agent, and disabling X11 forwarding. For consistency we can blank out PDSH_SSH_ARGS and set PDSH_SSH_ARGS_APPEND to FLINK_SSH_OPTS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-173244033
Since this tests that `pdsh` is available, this should be good to merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-173215668
I filed a JIRA for the failed test case: https://issues.apache.org/jira/browse/FLINK-3265
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3161][dist] Externalize cluster start-u...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1523#issuecomment-176853645
New commit that passes FLINK_SSH_OPTS to pdsh.
64 x c4.large
0m4.210s 0m4.181s
0m4.203s 0m4.283s
0m4.262s 0m4.196s
0m13.969s 0m12.533s
0m13.906s 0m13.169s
0m14.122s 0m12.343s
16 x c4.large
0m1.270s 0m1.267s
0m1.277s 0m1.164s
0m1.470s 0m1.180s
0m3.961s 0m2.985s
0m3.638s 0m3.014s
0m3.410s 0m3.159s
1 x c4.large
0m0.543s 0m0.449s
0m0.547s 0m1.300s
0m0.542s 0m0.452s
0m0.439s 0m1.247s
0m0.448s 0m1.439s
0m0.439s 0m0.827s
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---