[GitHub] [spark] Ngone51 commented on a change in pull request #29014: [SPARK-32199][SPARK-32198] Reduce job failures during decommissioning

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #29014:
URL: https://github.com/apache/spark/pull/29014#discussion_r453635661



##########
File path: core/src/main/scala/org/apache/spark/scheduler/ExecutorLossReason.scala
##########
@@ -54,10 +54,13 @@ private [spark] object LossReasonPending extends ExecutorLossReason("Pending los
 /**
  * @param _message human readable loss reason
  * @param workerLost whether the worker is confirmed lost too (i.e. including shuffle service)
+ *                   Used to know whether the shuffle data is lost too.
+ * @param causedByApp whether the loss of the slave is the fault of the running app. (assumed true
+ *                    by default unless known explicitly otherwise)
  */
 private[spark]
-case class SlaveLost(_message: String = "Slave lost", workerLost: Boolean = false)
-  extends ExecutorLossReason(_message)
+case class SlaveLost(_message: String = "Slave lost", workerLost: Boolean = false,
+                     causedByApp: Boolean = true) extends ExecutorLossReason(_message)

Review comment:
       nit:
   ```suggestion
   case class SlaveLost(
       _message: String = "Slave lost",
       workerLost: Boolean = false,
       causedByApp: Boolean = true)
     extends ExecutorLossReason(_message)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org