[GitHub] [incubator-doris] AshinGau commented on pull request #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy

[GitBox <gi...@apache.org>]

AshinGau commented on PR #9931:
URL: https://github.com/apache/incubator-doris/pull/9931#issuecomment-1145722630

   > > Will this cause the bug to be covered up? The decimal type doesn't seem to have precision errors
   > 
   > Maybe we should change this back after the decimal v3 is completed. Because currently, the decimal type doesn't return real precision.
   
   This fix was introduced for two reasons:
   1. The previous fix judges whether two numbers(float & double) are equal by the threshold of relative change. However, this is a fixed value, which may not solve the accuracy problem with larger error, so the rounding method may be better.
   2. Other correctness regression tests(tpch 100/1000) are prepared to be added, but the correct result sets come from other frameworks(Trino/Spark). Different frameworks cannot guarantee consistent behavior of decimal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org