You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/20 04:59:44 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #4850: ui: Consider overprovisioning factor when displaying allocated progre…

davidjumani opened a new pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850


   ### Description
   
   This PR fixes the UI info card by considering the overprovisioning factor while displaying the disk allocated progress bar
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [x] Trivial
   
   
   ### Screenshots (if appropriate):
   
   #### Before: 
   
   ![Screenshot from 2021-03-20 10-26-53](https://user-images.githubusercontent.com/8244774/111859459-20365300-8967-11eb-8846-80eee5457f22.png)
   
   #### After:
   
   ![Screenshot from 2021-03-20 10-26-37](https://user-images.githubusercontent.com/8244774/111859452-10b70a00-8967-11eb-80d9-4a1adec4d71d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-804922136


   Thanks all I'll merge based on your remarks and testing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-803746600


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-803758527


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4850 (SL-JID-47)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-803746478


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-803859036


   Primary storages is the only place where disksizeallocatedgb is used


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-803766138


   <b>[S] Trillian Build Failed (tid-186)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-803852166


   @rhtyd I compared primary storage capacity with and without changes
   ![Screenshot from 2021-03-22 13-30-15](https://user-images.githubusercontent.com/153340/111958287-0f2a4500-8b13-11eb-8b5d-149a5aee3796.png)
   Primary storages were the only place in UI where I could find these progress bars displayed
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-803805299


   @shwstppr @utchoang have you tested VM, volume, storage pool, snapshot and/or anything related to disk/storage?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-803771723


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] utchoang commented on pull request #4850: ui: Consider overprovisioning when displaying allocated progress

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4850:
URL: https://github.com/apache/cloudstack/pull/4850#issuecomment-803860094


   @rhtyd Tested in the primary storage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org