[GitHub] [arrow] alamb commented on a change in pull request #8930: ARROW-10929: [Rust] Change CI to use Stable Rust

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #8930:
URL: https://github.com/apache/arrow/pull/8930#discussion_r544677372



##########
File path: rust/datafusion/src/logical_plan/plan.rs
##########
@@ -561,6 +561,7 @@ impl From<&PlanType> for String {
 
 /// Represents some sort of execution plan, in String form
 #[derive(Debug, Clone, PartialEq)]
+#[allow(clippy::rc_buffer)]

Review comment:
       Clippy is complaining about https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer - but I think in this case using the Arc<String> is really about cheaply copying the `String` rather than it being mutable. The same happens for the other places I disabled this lint in this PR
   
   I am not enough of a Rust expert to know if there is some better way to pass around a cheaply cloneable `Vec` or `String` that would appease Clippy. 

##########
File path: rust/datafusion/src/lib.rs
##########
@@ -17,7 +17,6 @@
 #![warn(missing_docs)]
 // Clippy lints, some should be disabled incrementally
 #![allow(
-    clippy::field_reassign_with_default,

Review comment:
       this does not exist in stable clippy




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org