[GitHub] [iceberg] rdblue commented on a diff in pull request #5215: Core: Update MetricsConfig to use a default for first 32 columns

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5215:
URL: https://github.com/apache/iceberg/pull/5215#discussion_r915271111


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -267,6 +267,10 @@ private TableProperties() {
   public static final String METADATA_DELETE_AFTER_COMMIT_ENABLED = "write.metadata.delete-after-commit.enabled";
   public static final boolean METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT = false;
 
+  public static final String METRICS_MAX_INFERRED_COLUMN_DEFAULTS =

Review Comment:
   I debated what to call this. The problem is that we are defaulting the default. You can explicitly set a default using `write.metadata.metrics.default`, and that will apply to all columns. If you don't _set_ a default we _infer_ one for you, but only for the first 32 columns (at least, after this PR). That's why I used "inferred" -- I thought it was better than `max-defaulted-default-columns`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org