[GitHub] [pulsar] Jason918 commented on a change in pull request #13068: [PIP-45] Add support for etcd to implement interfaces

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #13068:
URL: https://github.com/apache/pulsar/pull/13068#discussion_r760716373



##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java
##########
@@ -0,0 +1,80 @@
+package org.apache.pulsar.metadata.impl;
+
+import io.etcd.jetcd.Client;
+import io.etcd.jetcd.KV;
+import io.etcd.jetcd.Lease;
+import io.etcd.jetcd.Watch;
+import org.apache.pulsar.metadata.api.GetResult;
+import org.apache.pulsar.metadata.api.MetadataStoreConfig;
+import org.apache.pulsar.metadata.api.Stat;
+import org.apache.pulsar.metadata.api.extended.CreateOption;
+import org.apache.pulsar.metadata.api.extended.MetadataStoreExtended;
+
+import java.time.temporal.ChronoUnit;
+import java.util.EnumSet;
+import java.util.List;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+
+public class EtcdMetadataStore extends AbstractMetadataStore implements MetadataStoreExtended {
+
+    //与bookie client保持通信的组件
+    private Client client;
+    //存储数据用的抽象
+    private KV kvClient;
+    //用于节点实例在定期watch之后进行续租
+    private Lease leaseClient;
+    //类似于zk当中的节点状态同步
+    private Watch watchClient;
+
+
+
+    public EtcdMetadataStore(String metadataURL, MetadataStoreConfig metadataStoreConfig){
+        this.client = Client.builder().endpoints(metadataURL)
+                .maxInboundMessageSize(metadataStoreConfig.getMaxInboundMessageSize())
+                .retryChronoUnit(ChronoUnit.MINUTES)
+                .retryMaxDuration(metadataStoreConfig.getRetryMaxDuration())
+                .retryDelay(metadataStoreConfig.getRetryDelay())
+                .build();
+
+        this.kvClient = client.getKVClient();
+        this.leaseClient = client.getLeaseClient();
+
+
+    }
+
+    @Override
+    public CompletableFuture<Optional<GetResult>> get(String path) {

Review comment:
       WIP ?
   There is no implementation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org