You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/23 12:07:28 UTC
[GitHub] [tvm] manupa-arm opened a new pull request #8312: Fix ordering of tf and tflite installs in ci_cpu
manupa-arm opened a new pull request #8312:
URL: https://github.com/apache/tvm/pull/8312
The recently merged #8306 introduced a depedencyfor tflite installation that tf must be installed first.However, that PR did not correct the ordering in ci_cpu which does not have that ordering.
cc : @leandron @mbrookhart @Lunderberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #8312: Fix ordering of tf and tflite installs in ci_cpu
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #8312:
URL: https://github.com/apache/tvm/pull/8312#issuecomment-866812020
Thank you for catching that. It looks like the `Dockerfile.ci_qemu` will run into the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #8312: Fix ordering of tf and tflite installs in ci_cpu
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #8312:
URL: https://github.com/apache/tvm/pull/8312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8312: Fix ordering of tf and tflite installs in ci_cpu
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8312:
URL: https://github.com/apache/tvm/pull/8312#issuecomment-867092775
CI failed on this one, due to a timeout. But CI doesn't really test anything related to the shell scripts on this PR. Based on that I'm gonna merge it, as I understand this was tested locally and is a necessary change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #8312: Fix ordering of tf and tflite installs in ci_cpu
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #8312:
URL: https://github.com/apache/tvm/pull/8312#issuecomment-867099597
Alright -- re-triggered it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron edited a comment on pull request #8312: Fix ordering of tf and tflite installs in ci_cpu
Posted by GitBox <gi...@apache.org>.
leandron edited a comment on pull request #8312:
URL: https://github.com/apache/tvm/pull/8312#issuecomment-867092775
CI failed on this one, due to a timeout. But CI doesn't really test anything related to the shell scripts on this PR. Based on that I'm gonna merge it, as I understand this was tested locally and is a necessary change. edit: we'll actually I can't.
@manupa-arm can you poke CI once you have a moment, so that we can merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org