You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/01/24 04:44:40 UTC
Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42691/
-----------------------------------------------------------
Review request for mesos, Greg Mann, Jie Yu, and Timothy Chen.
Bugs: MESOS-4484
https://issues.apache.org/jira/browse/MESOS-4484
Repository: mesos
Description
-------
Fix GMock warning in MasterTest.OrphanTasks.
Diffs
-----
src/tests/master_tests.cpp cd426fda633c2d665b9533271610863062b1ed4e
Diff: https://reviews.apache.org/r/42691/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.
Posted by haosdent huang <ha...@gmail.com>.
> On Feb. 14, 2016, 8:44 a.m., Timothy Chen wrote:
> > Sorry for the late review, I can't apply the review at this moment. Can you rebase?
I saw current code have already added this. Let me discard this patch.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42691/#review119174
-----------------------------------------------------------
On Jan. 24, 2016, 3:45 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42691/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 3:45 a.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4484
> https://issues.apache.org/jira/browse/MESOS-4484
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix GMock warning in MasterTest.OrphanTasks.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp cd426fda633c2d665b9533271610863062b1ed4e
>
> Diff: https://reviews.apache.org/r/42691/diff/
>
>
> Testing
> -------
>
> # warning didn't appear now.
> sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.OrphanTasks"
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42691/#review119174
-----------------------------------------------------------
Sorry for the late review, I can't apply the review at this moment. Can you rebase?
- Timothy Chen
On Jan. 24, 2016, 3:45 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42691/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 3:45 a.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4484
> https://issues.apache.org/jira/browse/MESOS-4484
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix GMock warning in MasterTest.OrphanTasks.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp cd426fda633c2d665b9533271610863062b1ed4e
>
> Diff: https://reviews.apache.org/r/42691/diff/
>
>
> Testing
> -------
>
> # warning didn't appear now.
> sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.OrphanTasks"
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42691/#review116007
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42691]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 24, 2016, 3:45 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42691/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2016, 3:45 a.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4484
> https://issues.apache.org/jira/browse/MESOS-4484
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix GMock warning in MasterTest.OrphanTasks.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp cd426fda633c2d665b9533271610863062b1ed4e
>
> Diff: https://reviews.apache.org/r/42691/diff/
>
>
> Testing
> -------
>
> # warning didn't appear now.
> sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.OrphanTasks"
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42691: Fix GMock warning in MasterTest.OrphanTasks.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42691/
-----------------------------------------------------------
(Updated Jan. 24, 2016, 3:45 a.m.)
Review request for mesos, Greg Mann, Jie Yu, and Timothy Chen.
Bugs: MESOS-4484
https://issues.apache.org/jira/browse/MESOS-4484
Repository: mesos
Description
-------
Fix GMock warning in MasterTest.OrphanTasks.
Diffs
-----
src/tests/master_tests.cpp cd426fda633c2d665b9533271610863062b1ed4e
Diff: https://reviews.apache.org/r/42691/diff/
Testing (updated)
-------
# warning didn't appear now.
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.OrphanTasks"
Thanks,
haosdent huang