You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/19 05:38:45 UTC

[GitHub] [spark] maropu commented on a change in pull request #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface

maropu commented on a change in pull request #25189: [SPARK-28435][SQL] Support cast StringType to IntervalType for SQL interface
URL: https://github.com/apache/spark/pull/25189#discussion_r305207441
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/cast.sql
 ##########
 @@ -53,6 +53,10 @@ SELECT HEX(CAST(-123 AS binary));
 SELECT HEX(CAST(123L AS binary));
 SELECT HEX(CAST(-123L AS binary));
 
+-- cast string to interval and interval to string
+SELECT CAST('interval 3 month 1 hour' AS interval);
+SELECT CAST(interval 3 month 1 hour AS string);
+
 
 Review comment:
   nit: Moves these tests in the end of this file?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org