[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #925: Move manifest factory methods

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #925: Move manifest factory methods
URL: https://github.com/apache/incubator-iceberg/pull/925#discussion_r409174861
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/ManifestReader.java
 ##########
 @@ -62,63 +61,18 @@
   /**
    * Returns a new {@link ManifestReader} for an {@link InputFile}.
    * <p>
-   * <em>Note:</em> Most callers should use {@link #read(ManifestFile, FileIO, Map)} to ensure that
+   * <em>Note:</em> Callers should use {@link ManifestFiles#read(ManifestFile, FileIO, Map)} to ensure that
    * manifest entries with partial metadata can inherit missing properties from the manifest metadata.
-   * <p>
-   * <em>Note:</em> Most callers should use {@link #read(InputFile, Map)} if all manifest entries
-   * contain full metadata and they want to ensure that the schema used by filters is the latest
-   * table schema. This should be used only when reading a manifest without filters.
    *
    * @param file an InputFile
    * @return a manifest reader
+   * @deprecated use {@link ManifestFiles#read(ManifestFile, FileIO, Map)}.
    */
+  @Deprecated
 
 Review comment:
   Looks like `read(InputFile, Map)` was also released in 0.7.0. I kept this one because I know we have people using it, but we can keep the other one as well. Do you think we should?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org