You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/14 07:04:56 UTC
[GitHub] [doris] github-actions[bot] commented on pull request #15926: [fix](thirdparty) patch sqltypes.h in odbc to avoid conflict with clucene TCHAR
github-actions[bot] commented on PR #15926:
URL: https://github.com/apache/doris/pull/15926#issuecomment-1382679331
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3917402084") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In thirdparty/download-thirdparty.sh line 350:
cd $TP_SOURCE_DIR/$ODBC_SOURCE
^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
cd "$TP_SOURCE_DIR"/$ODBC_SOURCE
In thirdparty/download-thirdparty.sh line 351:
if [ ! -f $PATCHED_MARK ]; then
^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
^-----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
if [[ ! -f "$PATCHED_MARK" ]]; then
In thirdparty/download-thirdparty.sh line 352:
patch -p1 < $TP_PATCH_DIR/sqltypes.h.patch
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
patch -p1 < "$TP_PATCH_DIR"/sqltypes.h.patch
In thirdparty/download-thirdparty.sh line 353:
touch $PATCHED_MARK
^-----------^ SC2248 (style): Prefer double quoting even when variables don't contain special characters.
^-----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
touch "$PATCHED_MARK"
In thirdparty/download-thirdparty.sh line 356:
echo "Finished patching $ODBC_SOURCE"
^----------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
echo "Finished patching ${ODBC_SOURCE}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2248 -- Prefer double quoting even when v...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around vari...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/download-thirdparty.sh.orig
+++ thirdparty/download-thirdparty.sh
@@ -349,7 +349,7 @@
#patch sqltypes.h
cd $TP_SOURCE_DIR/$ODBC_SOURCE
if [ ! -f $PATCHED_MARK ]; then
- patch -p1 < $TP_PATCH_DIR/sqltypes.h.patch
+ patch -p1 <$TP_PATCH_DIR/sqltypes.h.patch
touch $PATCHED_MARK
fi
cd -
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org