You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2005/04/15 07:00:47 UTC

Re: svn commit: r14231 - in branches/1.2.x: . subversion/bindings/java/javahl/native subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/tests

On Thu, 14 Apr 2005 dlr@tigris.org wrote:

> Author: dlr
> Date: Thu Apr 14 21:35:21 2005
> New Revision: 14231
>
> Modified:
>    branches/1.2.x/STATUS
>    branches/1.2.x/subversion/bindings/java/javahl/native/JNIUtil.cpp
>    branches/1.2.x/subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/tests/SVNTests.java
> Log:
> Fixed a crash from the new Notify2 implementation (a backport of r14183).
>
> * STATUS
>   Removed r14183.
>
> [in subversion/bindings/java/javahl]
>
> * native/JNIUtil.cpp
>  (JNIUtil::makeSVNErrorMessage): Do not try to transform a NULL error
>   into a string.
>
> * src/org/tigris/subversion/javahl/tests/SVNTests.java
>  (SVNTests.setUp): Add a notifier corresponding to the Notify2 interface.
>  (SVNTests.MyNotifier): New (no-op) Notify2 implementation.
>
> Reported by: Mark Phippard
> Submitted by: Patrick Mayweg
>

There is no need to duplicate the whole log message in a back-port (and it
is also harmful, if you have to propedit the original). We also usually
mention the voters in the backport log.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r14231 - in branches/1.2.x: . subversion/bindings/java/javahl/native subversion/bindings/java/javahl/src/org/tigris/subversion/javahl/tests

Posted by Daniel Rall <dl...@finemaltcoding.com>.
On Fri, 2005-04-15 at 09:00 +0200, Peter N. Lundblad wrote:
...
>There is no need to duplicate the whole log message in a back-port (and it
>is also harmful, if you have to propedit the original). We also usually
>mention the voters in the backport log.


Log messages adjusted, thanks.

- Dan


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org