You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/23 06:07:12 UTC

[GitHub] [flink] dawidwys commented on issue #8187: [FLINK-12197] [Formats] Avro row deser for Confluent binary format

dawidwys commented on issue #8187: [FLINK-12197] [Formats] Avro row deser for Confluent binary format
URL: https://github.com/apache/flink/pull/8187#issuecomment-485656187
 
 
   Hi @EugeneYushin I have not read the whole PR, but I have one general concern regarding the architecture of this change. Why do we need a whole duplicated `DeserializationSchema`? Can't we just wrap the original `AvroDeserializationSchema` and just introduce a wrapper that converts the output of the schema to `Row`?
   
   @flinkbot approve description
   @flinkbot diapprove consensus

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services