You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jonathanc-n (via GitHub)" <gi...@apache.org> on 2025/03/21 21:49:48 UTC
[PR] feat: Add merge summary and add manifest functionality to `SnapshotSummary` [iceberg-rust]
jonathanc-n opened a new pull request, #1122:
URL: https://github.com/apache/iceberg-rust/pull/1122
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Part of #724 .
## What changes are included in this PR?
Added functionality for merging summary and adding manifest file information.
<!--
Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
One unit test for merge functionality and add manifest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add merge summary and add manifest functionality to `SnapshotSummary` [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #1122:
URL: https://github.com/apache/iceberg-rust/pull/1122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] feat: Add merge summary and add manifest functionality to `SnapshotSummary` [iceberg-rust]
Posted by "dentiny (via GitHub)" <gi...@apache.org>.
dentiny commented on code in PR #1122:
URL: https://github.com/apache/iceberg-rust/pull/1122#discussion_r3212593432
##########
crates/iceberg/src/spec/snapshot_summary.rs:
##########
@@ -55,6 +55,7 @@ pub struct SnapshotSummaryCollector {
partition_metrics: HashMap<String, UpdateMetrics>,
max_changed_partitions_for_summaries: u64,
properties: HashMap<String, String>,
+ trust_partition_metrics: bool,
Review Comment:
curious how do we plan to use `trust_partition_metrics`?
- It's by default false and never set to true anywhere
- It's of private visibility which cannot be set true outside
- It's not taking any affect in `build()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org