[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #11765: Bump up dependencies to fix cves

[GitBox <gi...@apache.org>]

kezhenxu94 commented on code in PR #11765:
URL: https://github.com/apache/dolphinscheduler/pull/11765#discussion_r962285779


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/SpringConnectionFactory.java:
##########
@@ -51,8 +53,10 @@ public class SpringConnectionFactory {
     public DataSourceScriptDatabaseInitializer dataSourceScriptDatabaseInitializer;
 
     @Bean
-    public PaginationInterceptor paginationInterceptor() {
-        return new PaginationInterceptor();
+    public MybatisPlusInterceptor paginationInterceptor() {
+        MybatisPlusInterceptor interceptor = new MybatisPlusInterceptor();
+        interceptor.addInnerInterceptor(new PaginationInnerInterceptor(DbType.MYSQL));

Review Comment:
   > Don't other databases need to be handled?
   
   Uh... forgot to pass the db type here, now fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org