You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ju...@apache.org on 2015/11/30 20:35:29 UTC
incubator-reef git commit: [REEF-1013] C# Evaluator does not work on
HDInsight This addressed the issue by * Adding an alias parameter to identify
``TempFileCreator``, which is used in the Hadoop runtime evaluator.conf.
Repository: incubator-reef
Updated Branches:
refs/heads/master 4d8da5294 -> 66ddb2440
[REEF-1013] C# Evaluator does not work on HDInsight
This addressed the issue by
* Adding an alias parameter to identify ``TempFileCreator``, which is used in the Hadoop runtime evaluator.conf.
JIRA:
[REEF-1013](https://issues.apache.org/jira/browse/REEF-1013)
This closes #679
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/66ddb244
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/66ddb244
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/66ddb244
Branch: refs/heads/master
Commit: 66ddb2440022c3db2628e671a59f406138117e8b
Parents: 4d8da52
Author: Andrew Chung <af...@apache.org>
Authored: Wed Nov 25 20:58:30 2015 -0800
Committer: Julia Wang <ju...@apache.org>
Committed: Mon Nov 30 11:32:11 2015 -0800
----------------------------------------------------------------------
.../reef/runtime/common/evaluator/EvaluatorConfiguration.java | 3 +++
.../org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/66ddb244/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java
index 1df8ffa..1316e33 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/evaluator/EvaluatorConfiguration.java
@@ -18,6 +18,8 @@
*/
package org.apache.reef.runtime.common.evaluator;
+import org.apache.reef.io.TempFileCreator;
+import org.apache.reef.io.WorkingDirectoryTempFileCreator;
import org.apache.reef.runtime.common.evaluator.parameters.*;
import org.apache.reef.runtime.common.launch.parameters.ErrorHandlerRID;
import org.apache.reef.runtime.common.launch.parameters.LaunchID;
@@ -67,6 +69,7 @@ public final class EvaluatorConfiguration extends ConfigurationModuleBuilder {
* This is ConfigurationModule for Java Evaluator.
*/
public static final ConfigurationModule CONF = EVALUATOR_CONFIG_MODULE_BUILDER
+ .bindImplementation(TempFileCreator.class, WorkingDirectoryTempFileCreator.class)
.bindSetEntry(Clock.RuntimeStartHandler.class, EvaluatorRuntime.RuntimeStartHandler.class)
.bindSetEntry(Clock.RuntimeStopHandler.class, EvaluatorRuntime.RuntimeStopHandler.class)
.bindConstructor(ExecutorService.class, ExecutorServiceConstructor.class)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/66ddb244/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java
index 00f26b6..b5b59a9 100644
--- a/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java
+++ b/lang/java/reef-runtime-yarn/src/main/java/org/apache/reef/runtime/yarn/driver/EvaluatorSetupHelper.java
@@ -22,7 +22,6 @@ import org.apache.hadoop.fs.Path;
import org.apache.hadoop.yarn.api.records.LocalResource;
import org.apache.reef.annotations.audience.DriverSide;
import org.apache.reef.io.TempFileCreator;
-import org.apache.reef.io.WorkingDirectoryTempFileCreator;
import org.apache.reef.runtime.common.driver.api.ResourceLaunchEvent;
import org.apache.reef.runtime.common.files.JobJarMaker;
import org.apache.reef.runtime.common.files.REEFFileNames;
@@ -141,7 +140,6 @@ final class EvaluatorSetupHelper {
throws IOException {
return Tang.Factory.getTang()
.newConfigurationBuilder(resourceLaunchEvent.getEvaluatorConf())
- .bindImplementation(TempFileCreator.class, WorkingDirectoryTempFileCreator.class)
.build();
}
}