You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/27 08:40:30 UTC

[GitHub] [airflow] ashb commented on pull request #16002: fix remote logging when blob already exists

ashb commented on pull request #16002:
URL: https://github.com/apache/airflow/pull/16002#issuecomment-849451480


   > > If `append=False, overwrite=False` is invalid, and `append=True, overwrite=True` simply means append, I would just have one `append` kwargs (i.e. dont add any new arguments), and have `append=False` automatically overwrite. This should be good enough as long as we document the behaivour.
   > 
   > Good. @flolas make this change.
   > @jhtimmins @uranusjr part of my worry in this PR is whether we should really overwrite? Will it come to users as surprise?
   
   The S3 logger appends if the object already exists, so that is what we should do here too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org