You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Julian Hyde <jh...@apache.org> on 2017/09/07 17:44:00 UTC
Javadoc errors
Jesus,
I am seeing javadoc errors when I run "mvn site" (under JDK 1.8 on
Windows, as it happens) that are very likely from your CALCITE-1947
commit. Can you fix ASAP.
Julian
Re: Javadoc errors
Posted by Jesus Camacho Rodriguez <jc...@apache.org>.
Sure, I will. Thanks for fixing these Julian.
-Jesús
On 9/8/17, 1:44 PM, "Julian Hyde" <jh...@apache.org> wrote:
>And I discovered two more breakages from that change.
>
>SqlTypeFamily references java.sql.Types.TIMESTAMP_WITH_TIMEZONE, which doesn’t exist in JDK 1.7, which breaks the build under JDK 1.7.
>
>And Long(long) constructor is deprecated in JDK 1.9, which generates a deprecation warning (which we treat as a build error) under JDK 1.9.
>
>I’ll fix them.
>
>But this close to the release, please run under JDK 1.7, 1.8 and 1.9, including javadoc and checking for deprecation warnings, before every commit.
>
>Julian
>
>
>> On Sep 7, 2017, at 1:50 PM, Jesus Camacho Rodriguez <jc...@apache.org> wrote:
>>
>> Julian,
>>
>> I cannot repro in my environment. Could you share the errors that you are seeing?
>>
>> Thanks,
>>
>> -Jesús
>>
>>
>>
>> On 9/7/17, 1:12 PM, "Jesus Camacho Rodriguez" <jcamachorodriguez@hortonworks.com on behalf of jcamacho@apache.org> wrote:
>>
>>> Sure, let me take a look.
>>>
>>> -Jesús
>>>
>>>
>>>
>>>
>>> On 9/7/17, 10:44 AM, "Julian Hyde" <jh...@apache.org> wrote:
>>>
>>>> Jesus,
>>>>
>>>> I am seeing javadoc errors when I run "mvn site" (under JDK 1.8 on
>>>> Windows, as it happens) that are very likely from your CALCITE-1947
>>>> commit. Can you fix ASAP.
>>>>
>>>> Julian
>>>>
>>>
>>
>
Re: Javadoc errors
Posted by Julian Hyde <jh...@apache.org>.
And I discovered two more breakages from that change.
SqlTypeFamily references java.sql.Types.TIMESTAMP_WITH_TIMEZONE, which doesn’t exist in JDK 1.7, which breaks the build under JDK 1.7.
And Long(long) constructor is deprecated in JDK 1.9, which generates a deprecation warning (which we treat as a build error) under JDK 1.9.
I’ll fix them.
But this close to the release, please run under JDK 1.7, 1.8 and 1.9, including javadoc and checking for deprecation warnings, before every commit.
Julian
> On Sep 7, 2017, at 1:50 PM, Jesus Camacho Rodriguez <jc...@apache.org> wrote:
>
> Julian,
>
> I cannot repro in my environment. Could you share the errors that you are seeing?
>
> Thanks,
>
> -Jesús
>
>
>
> On 9/7/17, 1:12 PM, "Jesus Camacho Rodriguez" <jcamachorodriguez@hortonworks.com on behalf of jcamacho@apache.org> wrote:
>
>> Sure, let me take a look.
>>
>> -Jesús
>>
>>
>>
>>
>> On 9/7/17, 10:44 AM, "Julian Hyde" <jh...@apache.org> wrote:
>>
>>> Jesus,
>>>
>>> I am seeing javadoc errors when I run "mvn site" (under JDK 1.8 on
>>> Windows, as it happens) that are very likely from your CALCITE-1947
>>> commit. Can you fix ASAP.
>>>
>>> Julian
>>>
>>
>
Re: Javadoc errors
Posted by Jesus Camacho Rodriguez <jc...@apache.org>.
Thanks Julian, I have pushed the fix.
-Jesús
On 9/7/17, 2:01 PM, "Julian Hyde" <jh...@apache.org> wrote:
>Here is the output I get. Make sure you are using JDK 1.8.
>
>[ERROR] /home/jhyde/open1/calcite.2/core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java:182:
>error: reference not found
>[ERROR] * {@link
>RexBuilder#makeTimestampWithLocalTimeZoneLiteral(TimestampWithTimeZoneString,
>int)}. */
>[ERROR] ^
>[ERROR]
>[ERROR] Command line was:
>/old/usr/lib/jvm/jdk1.8.0_121/jre/../bin/javadoc @options @packages
>@argfile
>
>Julian
>
>
>On Thu, Sep 7, 2017 at 1:50 PM, Jesus Camacho Rodriguez
><jc...@apache.org> wrote:
>> Julian,
>>
>> I cannot repro in my environment. Could you share the errors that you are seeing?
>>
>> Thanks,
>>
>> -Jesús
>>
>>
>>
>> On 9/7/17, 1:12 PM, "Jesus Camacho Rodriguez" <jcamachorodriguez@hortonworks.com on behalf of jcamacho@apache.org> wrote:
>>
>>>Sure, let me take a look.
>>>
>>>-Jesús
>>>
>>>
>>>
>>>
>>>On 9/7/17, 10:44 AM, "Julian Hyde" <jh...@apache.org> wrote:
>>>
>>>>Jesus,
>>>>
>>>>I am seeing javadoc errors when I run "mvn site" (under JDK 1.8 on
>>>>Windows, as it happens) that are very likely from your CALCITE-1947
>>>>commit. Can you fix ASAP.
>>>>
>>>>Julian
>>>>
>>>
>>
>
Re: Javadoc errors
Posted by Julian Hyde <jh...@apache.org>.
Here is the output I get. Make sure you are using JDK 1.8.
[ERROR] /home/jhyde/open1/calcite.2/core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java:182:
error: reference not found
[ERROR] * {@link
RexBuilder#makeTimestampWithLocalTimeZoneLiteral(TimestampWithTimeZoneString,
int)}. */
[ERROR] ^
[ERROR]
[ERROR] Command line was:
/old/usr/lib/jvm/jdk1.8.0_121/jre/../bin/javadoc @options @packages
@argfile
Julian
On Thu, Sep 7, 2017 at 1:50 PM, Jesus Camacho Rodriguez
<jc...@apache.org> wrote:
> Julian,
>
> I cannot repro in my environment. Could you share the errors that you are seeing?
>
> Thanks,
>
> -Jesús
>
>
>
> On 9/7/17, 1:12 PM, "Jesus Camacho Rodriguez" <jcamachorodriguez@hortonworks.com on behalf of jcamacho@apache.org> wrote:
>
>>Sure, let me take a look.
>>
>>-Jesús
>>
>>
>>
>>
>>On 9/7/17, 10:44 AM, "Julian Hyde" <jh...@apache.org> wrote:
>>
>>>Jesus,
>>>
>>>I am seeing javadoc errors when I run "mvn site" (under JDK 1.8 on
>>>Windows, as it happens) that are very likely from your CALCITE-1947
>>>commit. Can you fix ASAP.
>>>
>>>Julian
>>>
>>
>
Re: Javadoc errors
Posted by Jesus Camacho Rodriguez <jc...@apache.org>.
Julian,
I cannot repro in my environment. Could you share the errors that you are seeing?
Thanks,
-Jesús
On 9/7/17, 1:12 PM, "Jesus Camacho Rodriguez" <jcamachorodriguez@hortonworks.com on behalf of jcamacho@apache.org> wrote:
>Sure, let me take a look.
>
>-Jesús
>
>
>
>
>On 9/7/17, 10:44 AM, "Julian Hyde" <jh...@apache.org> wrote:
>
>>Jesus,
>>
>>I am seeing javadoc errors when I run "mvn site" (under JDK 1.8 on
>>Windows, as it happens) that are very likely from your CALCITE-1947
>>commit. Can you fix ASAP.
>>
>>Julian
>>
>
Re: Javadoc errors
Posted by Jesus Camacho Rodriguez <jc...@apache.org>.
Sure, let me take a look.
-Jesús
On 9/7/17, 10:44 AM, "Julian Hyde" <jh...@apache.org> wrote:
>Jesus,
>
>I am seeing javadoc errors when I run "mvn site" (under JDK 1.8 on
>Windows, as it happens) that are very likely from your CALCITE-1947
>commit. Can you fix ASAP.
>
>Julian
>