You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "lamber-ken (Jira)" <ji...@apache.org> on 2019/12/06 07:54:00 UTC
[jira] [Updated] (HUDI-385) Refactor hudi scala checkstyle
[ https://issues.apache.org/jira/browse/HUDI-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
lamber-ken updated HUDI-385:
----------------------------
Description:
Currently, the level of scala codestyle rule is warning, it's better check these rules one by one and refactor scala codes then now.
Furthermore, in order to sync to java codestyle, needs to add two rules. One is BlockImportChecker which allows to ensure that only single imports are used in order to minimize merge errors in import declarations,
another is ImportOrderChecker which checks that imports are grouped and ordered according to the style configuration.
Summary
1, check scala checkstyle rules one by one, change some warning level to error.
2, add ImportOrderChecker and BlockImportChecker.
was:Currently, the level of scala codestyle rule is warning, it's better check these rules one by one and refactor scala codes then now. Furthermore, in order to sync to java codestyle, needs to add two rules. One is BlockImportChecker which allows to ensure that only single imports are used in order to minimize merge errors in import declarations, another is ImportOrderChecker which checks that imports are grouped and ordered according to the style configuration. Summary 1, check scala checkstyle rules one by one, change some warning level to error. 2, add ImportOrderChecker and BlockImportChecker. Any comments and feedback are welcome, WDYT?
> Refactor hudi scala checkstyle
> ------------------------------
>
> Key: HUDI-385
> URL: https://issues.apache.org/jira/browse/HUDI-385
> Project: Apache Hudi (incubating)
> Issue Type: Improvement
> Reporter: lamber-ken
> Priority: Major
>
> Currently, the level of scala codestyle rule is warning, it's better check these rules one by one and refactor scala codes then now.
>
> Furthermore, in order to sync to java codestyle, needs to add two rules. One is BlockImportChecker which allows to ensure that only single imports are used in order to minimize merge errors in import declarations,
> another is ImportOrderChecker which checks that imports are grouped and ordered according to the style configuration.
>
> Summary
> 1, check scala checkstyle rules one by one, change some warning level to error.
> 2, add ImportOrderChecker and BlockImportChecker.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)