You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/11/23 18:28:43 UTC
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #570: ORC-685: Add `ReaderImpl.extractFileTail` back
dongjoon-hyun commented on a change in pull request #570:
URL: https://github.com/apache/orc/pull/570#discussion_r528911408
##########
File path: java/core/src/java/org/apache/orc/impl/ReaderImpl.java
##########
@@ -436,6 +436,31 @@ protected static void ensureOrcFooter(FSDataInputStream in,
}
}
+ /**
+ * Ensure this is an ORC file to prevent users from trying to read text
+ * files or RC files as ORC files.
+ * @param psLen the postscript length
+ * @param buffer the tail of the file
+ */
+ protected static void ensureOrcFooter(ByteBuffer buffer, int psLen) throws IOException {
Review comment:
Could you add `@deprecated` to give a proper warning?
##########
File path: java/core/src/java/org/apache/orc/impl/ReaderImpl.java
##########
@@ -643,6 +668,48 @@ private static void read(FSDataInputStream file,
}
}
+ public static OrcTail extractFileTail(ByteBuffer buffer)
Review comment:
Could you add `@deprecated` to give a proper warning?
##########
File path: java/core/src/java/org/apache/orc/impl/ReaderImpl.java
##########
@@ -643,6 +668,48 @@ private static void read(FSDataInputStream file,
}
}
+ public static OrcTail extractFileTail(ByteBuffer buffer)
+ throws IOException {
+ return extractFileTail(buffer, -1);
+ }
+
+ public static OrcTail extractFileTail(ByteBuffer buffer, long modificationTime)
Review comment:
Could you add `@deprecated` to give a proper warning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org