[jira] [Commented] (BEAM-6007) Create ClassLoadingStrategy with Java 11 compatible way

["Tyson Hamilton (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206370#comment-17206370 ] 

Tyson Hamilton commented on BEAM-6007:
--------------------------------------

I've looked into this a bit and wanted to just update with my findings. My testing shows this is no longer an issue.

This Jira issue was created on 06/11/2018, less than a week after Beam updated bytebuddy from 1.8.11 to 1.9.3 ([https://github.com/apache/beam/commit/9c47dc1e403fa5f107220142797614cae7280af4).] According to the bytebuddy release notes for 1.8.16 ([https://github.com/raphw/byte-buddy/blob/master/release-notes.md#3-august-2018-version-1816):]
 * Reenable {{ClassFileInjection.Default.INJECTION}} in Java 11+ via fallback onto {{Unsafe::putBoolean}}.

My best guess is that the reporter just missed the version bump. I'm going to close this, but if someone can demonstrate it is still an issue with a repro, please reopen.

> Create ClassLoadingStrategy with Java 11 compatible way
> -------------------------------------------------------
>
>                 Key: BEAM-6007
>                 URL: https://issues.apache.org/jira/browse/BEAM-6007
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Keisuke Kondo
>            Priority: P2
>
> Since sun.misc.Unsafe API was deprecated in Java 11,
>  
> {code:java}
> ClassLoadingStrategy.Default.INJECTION{code}
> is not work with Java 11.
> Author of byte-buddy library shared way to make it compatible with Java 11 on his blog post. (and way to keep compatibility with java 9 and prior version)
> [http://mydailyjava.blogspot.com/2018/04/jdk-11-and-proxies-in-world-past.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)