You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/02/18 13:41:15 UTC
[GitHub] [hive] shameersss1 opened a new pull request #916: HIVE-22900 :
Predicate Push Down Of Like Filter While Fetching Partition Data From
MetaStore
shameersss1 opened a new pull request #916: HIVE-22900 : Predicate Push Down Of Like Filter While Fetching Partition Data From MetaStore
URL: https://github.com/apache/hive/pull/916
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #916:
HIVE-22900 : Predicate Push Down Of Like Filter While Fetching Partition
Data From MetaStore
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #916: HIVE-22900 : Predicate Push Down Of Like Filter While Fetching Partition Data From MetaStore
URL: https://github.com/apache/hive/pull/916#discussion_r384772777
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
##########
@@ -1222,6 +1217,10 @@ public void visit(LeafNode node) throws MetaException {
params.add(nodeValue);
}
+ if (node.operator == Operator.LIKE) {
+ nodeValue0 = nodeValue0 + " ESCAPE '\\' ";
Review comment:
Can you add a comment about this line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] shameersss1 commented on a change in pull request #916:
HIVE-22900 : Predicate Push Down Of Like Filter While Fetching Partition
Data From MetaStore
Posted by GitBox <gi...@apache.org>.
shameersss1 commented on a change in pull request #916: HIVE-22900 : Predicate Push Down Of Like Filter While Fetching Partition Data From MetaStore
URL: https://github.com/apache/hive/pull/916#discussion_r385043264
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
##########
@@ -1222,6 +1217,10 @@ public void visit(LeafNode node) throws MetaException {
params.add(nodeValue);
}
+ if (node.operator == Operator.LIKE) {
+ nodeValue0 = nodeValue0 + " ESCAPE '\\' ";
Review comment:
Added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asfgit closed pull request #916: HIVE-22900 : Predicate Push
Down Of Like Filter While Fetching Partition Data From MetaStore
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #916: HIVE-22900 : Predicate Push Down Of Like Filter While Fetching Partition Data From MetaStore
URL: https://github.com/apache/hive/pull/916
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org