[GitHub] [incubator-pegasus] levy5307 commented on a diff in pull request #1246: fix: fix log header not corresponding to level

[GitBox <gi...@apache.org>]

levy5307 commented on code in PR #1246:
URL: https://github.com/apache/incubator-pegasus/pull/1246#discussion_r1024813689


##########
src/utils/simple_logger.cpp:
##########
@@ -56,7 +56,7 @@ DSN_DEFINE_validator(stderr_start_level, [](const char *level) -> bool {
 
 static void print_header(FILE *fp, dsn_log_level_t log_level)
 {
-    static char s_level_char[] = "IDWEF";

Review Comment:
   It's better to add an explain to show what is 'I'/'D', and so on.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org