You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/06/19 23:13:55 UTC
[GitHub] incubator-brooklyn pull request: Remove redundant (and failing) te...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/702
Remove redundant (and failing) test
Functionality covered with next test (without it being integration). Turns out IP 0.0.0.0 points to localhost ports. Ad blockers should reconsider using it :).
Also use port which is known to not be bound, instead of hard coding.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn fix/integration-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #702
----
commit 79cb98c2f6bfc222cf9a949c45f3889cc0e6573d
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-06-19T21:04:54Z
Remove redundant test
Functionality covered with next test (without it being integration). Turns out IP 0.0.0.0 points to localhost ports.
Also use port which is known to not be bound, instead of hardcoding.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove redundant (and failing) te...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/702
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove redundant (and failing) te...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/702#issuecomment-113654721
Nice and simple; looks good. Will wait for CI to confirm before merging this time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---