[jira] [Commented] (PHOENIX-3748) sqlline.py, sqlline-thin.py are using the wrong variables.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935724#comment-15935724 ] 

Hadoop QA commented on PHOENIX-3748:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12859835/PHOENIX-3748.patch
  against master branch at commit 2074d1f0a2dd2b03c2e3588ffd4d5f2395cc7505.
  ATTACHMENT ID: 12859835

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 45 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/810//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/810//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/810//console

This message is automatically generated.

> sqlline.py, sqlline-thin.py are using the wrong variables.
> ----------------------------------------------------------
>
>                 Key: PHOENIX-3748
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3748
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.6.0, 4.8.0
>            Reporter: Soonho Kim
>            Priority: Trivial
>              Labels: patch
>         Attachments: PHOENIX-3748.patch
>
>
> It seems that the hbase_config_path variable in the sqlline.py and sqlline-thin.py scripts, are looking for invalid values.
> These variables should use the value "phoenix_utils.hbase_conf_dir" instead of "phoenix_utils.current_dir".
> -hbase_config_path = os.getenv('HBASE_CONF_DIR', phoenix_utils.current_dir)
> +hbase_config_path = os.getenv('HBASE_CONF_DIR', phoenix_utils.hbase_conf_dir)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)