You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/04/10 18:26:49 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request #1083: Make Monitor
service non-static
ctubbsii opened a new pull request #1083: Make Monitor service non-static
URL: https://github.com/apache/accumulo/pull/1083
* Convert all static fields/methods in Monitor to instance members
(except for constants)
* Use dependency injection to wire the Monitor through Jetty and into
the Jersey application resources
* Remove unnecessary code to asynchronously get the instanceName (it's
available on server startup, and can be obtained from the ServerContext)
* Ensure the Monitor is properly instantiated with the ServerContext
* Simplify fetching lock mechanism (using a simple AtomicBoolean instead
of synchronization)
* Simplify some Monitor internals, especially those pertaining to
initializing container resources by inlining MaxList into an anonymous
subclass of LinkedList that is constructed by a convenience method; this
makes some of the many Monitor members more readable by reducing the
number of lines which are wrapped to construct these lists
* Remove unnecessary members and group static constants together at the
top of the class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services