You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/03/21 07:47:41 UTC
[jira] [Commented] (FLUME-881) Would be nice if HDFS Sink would
automatically choose best writableFormat based on fileType
[ https://issues.apache.org/jira/browse/FLUME-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234169#comment-13234169 ]
jiraposter@reviews.apache.org commented on FLUME-881:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3146/
-----------------------------------------------------------
(Updated 2012-03-21 06:46:22.154059)
Review request for Flume, Arvind Prabhakar and Eric Sammer.
Summary
-------
I've put "dynamic default value" as is described in the JIRA. Please note that this patch is not working properly without patch from FLUME-880.
This addresses bug FLUME-881.
https://issues.apache.org/jira/browse/FLUME-881
Diffs
-----
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1212827
Diff: https://reviews.apache.org/r/3146/diff
Testing
-------
I've tested it on my test cluster, no formal tests were included.
Thanks,
Jarek
> Would be nice if HDFS Sink would automatically choose best writableFormat based on fileType
> -------------------------------------------------------------------------------------------
>
> Key: FLUME-881
> URL: https://issues.apache.org/jira/browse/FLUME-881
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Priority: Minor
>
> Currently user can specify both file type (SequenceFile, DataStream, ...) and writable format (Text ~ append new line character, Writable ~ serialize as is) of HDFS sink output file. Both properties have default values, however when user redefine only file type to DataStream, flume will still use default Writable writable format that will not append separate serialized events with new line character.
> Would be nice if flume would choose default value of writable format based on current file type, so that for example for DataStream file type, default writable format would be Text instead of Writable. I believe that would lead to less confused users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira