[GitHub] [spark] tgravescs commented on a change in pull request #27812: [SPARK-31055][DOCS] Update config docs for shuffle local host reads to have dep on external shuffle service

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #27812: [SPARK-31055][DOCS] Update config docs for shuffle local host reads to have dep on external shuffle service
URL: https://github.com/apache/spark/pull/27812#discussion_r388596812
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -1135,7 +1135,8 @@ package object config {
 
   private[spark] val SHUFFLE_HOST_LOCAL_DISK_READING_ENABLED =
     ConfigBuilder("spark.shuffle.readHostLocalDisk")
-      .doc(s"If enabled (and `${SHUFFLE_USE_OLD_FETCH_PROTOCOL.key}` is disabled), shuffle " +
+      .doc(s"If enabled (and `${SHUFFLE_USE_OLD_FETCH_PROTOCOL.key}` is disabled and external " +
+        s"`shuffle ${SHUFFLE_SERVICE_ENABLED.key}` is enabled), shuffle " +
 
 Review comment:
   yes you are right on the `, I accidentally wrapped things afterwards.
   
   I think its better here to be explicit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org