You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2019/08/19 01:49:26 UTC

[GitHub] [incubator-singa] nudles commented on a change in pull request #520: SINGA-474 add operator

nudles commented on a change in pull request #520: SINGA-474 add operator
URL: https://github.com/apache/incubator-singa/pull/520#discussion_r315016427
 
 

 ##########
 File path: python/singa/autograd.py
 ##########
 @@ -611,10 +612,17 @@ def __init__(self):
         super(Add, self).__init__()
 
     def forward(self, a, b):
+        self.shape0=list(a.shape())
+        self.shape1=list(b.shape())
 
 Review comment:
   can it handle the case that a is a matrix and b is a vector?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services