[jira] [Commented] (OAK-9159) Add test support to NodeStoreTask

["Julian Sedding (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-9159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168002#comment-17168002 ] 

Julian Sedding commented on OAK-9159:
-------------------------------------

Thanks for opening this ticket [~stefanegli]. First of all, please note that I'm not attached to any particular outcome to this ticket.

IIUC, the addition of the method {{DocumentNodeStore.stopBackgroundUpdateThread}} to the API implies that once released, it cannot be simply removed. So for this ticket to be valuable, this method would need to be removed again before the current committed state is released. I cannot say if this (hopefully) small refactoring would provide any other benefits beyond avoiding an API change.

> Add test support to NodeStoreTask
> ---------------------------------
>
>                 Key: OAK-9159
>                 URL: https://issues.apache.org/jira/browse/OAK-9159
>             Project: Jackrabbit Oak
>          Issue Type: Test
>          Components: documentmk
>    Affects Versions: 1.32.0
>            Reporter: Stefan Egli
>            Priority: Major
>
> As suggested by [~jsedding] in [this PR review comment|https://github.com/apache/jackrabbit-oak/pull/243#discussion_r462359594] the newly introduced (test method) {{DocumentNodeStore.stopBackgroundUpdateThread}} could be more elegantly implemented via a thread-factory approach. We should look into refactoring that code along those lines, if feasible extending the approach to the other background tasks too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)