You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by vahidhashemian <gi...@git.apache.org> on 2016/06/10 23:57:31 UTC
[GitHub] kafka pull request #1495: Minor: Respect the default value for partition arg...
GitHub user vahidhashemian opened a pull request:
https://github.com/apache/kafka/pull/1495
Minor: Respect the default value for partition argument in SimpleConsumerShell
The `partition` argument is not marked as required, and has a default of `0`, according to the tool's help message. However, if `partition` is not provided the command returns with `Missing required argument "[partition]"`. This patch is to fix the required arguments of the tool by removing `partition` from them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vahidhashemian/kafka minor/simple_consumer_shell_update_required_args
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1495.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1495
----
commit 54e7fba208d83526044d78b8ae85a428cb94157e
Author: Vahid Hashemian <va...@us.ibm.com>
Date: 2016-06-10T23:53:07Z
Minor: Respect the default value for partition argument in SimpleConsumerShell
The 'partition' argument is not marked as required, and has a default of 0, according to the tool's help message.
However, if 'partition' is not provided the command returns with 'Missing required argument "[partition]"'.
This patch is to fix the required arguments of the tool by removing 'partition' from them.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #1495: MINOR: Respect the default value of partition argu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/1495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---