You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by craighahnparsons <gi...@git.apache.org> on 2016/03/23 03:47:53 UTC
[GitHub] incubator-rya pull request: Added data type in tuple creation
GitHub user craighahnparsons opened a pull request:
https://github.com/apache/incubator-rya/pull/33
Added data type in tuple creation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/craighahnparsons/incubator-rya RYA-36-Fix-PIG-script-output
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 4a73be7ab8afe24faf9b871f5e11c9c3ca5f034a
Author: craighahnparsons <cr...@parsons.com>
Date: 2016-03-17T18:31:36Z
Added data type in tuple creation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: Added data type in tuple creation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request: Added data type in tuple creation
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/33#discussion_r63051791
--- Diff: pig/accumulo.pig/src/main/java/mvm/rya/accumulo/pig/StatementPatternStorage.java ---
@@ -289,11 +289,14 @@ public Tuple getNext() throws IOException {
RyaStatement ryaStatement = ryaContext.deserializeTriple(layout, new TripleRow(key.getRow().getBytes(),
key.getColumnFamily().getBytes(), key.getColumnQualifier().getBytes()));
- Tuple tuple = TupleFactory.getInstance().newTuple(4);
+ Tuple tuple = TupleFactory.getInstance().newTuple(7);
tuple.set(0, ryaStatement.getSubject().getData());
tuple.set(1, ryaStatement.getPredicate().getData());
tuple.set(2, ryaStatement.getObject().getData());
tuple.set(3, (ryaStatement.getContext() != null) ? (ryaStatement.getContext().getData()) : (null));
+ tuple.set(4, ryaStatement.getSubject().getDataType());
+ tuple.set(5, ryaStatement.getPredicate().getDataType());
+ tuple.set(6, ryaStatement.getObject().getDataType());
--- End diff --
Not a big deal, but you only need to set the data type on the object -- subjects/predicates are always uris by default. not a huge issue, I'll merge it regardless.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---