You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by il...@apache.org on 2018/11/07 09:44:20 UTC
[incubator-dubbo] branch master updated: #2748: Provider should
disable mock configuration (#2749)
This is an automated email from the ASF dual-hosted git repository.
iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new b0107e7 #2748: Provider should disable mock configuration (#2749)
b0107e7 is described below
commit b0107e767651d066d68c3beaaca9736aed2292b8
Author: Ian Luo <ia...@gmail.com>
AuthorDate: Wed Nov 7 17:43:55 2018 +0800
#2748: Provider should disable mock configuration (#2749)
---
.../src/main/java/org/apache/dubbo/config/ServiceConfig.java | 10 ++++++++++
.../test/java/org/apache/dubbo/config/ServiceConfigTest.java | 12 ++++++++++++
2 files changed, 22 insertions(+)
diff --git a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
index 42abc00..66e8d7f 100644
--- a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
+++ b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
@@ -818,6 +818,16 @@ public class ServiceConfig<T> extends AbstractServiceConfig {
}
}
+ @Override
+ public void setMock(Boolean mock) {
+ throw new IllegalArgumentException("mock doesn't support on provider side");
+ }
+
+ @Override
+ public void setMock(String mock) {
+ throw new IllegalArgumentException("mock doesn't support on provider side");
+ }
+
public List<URL> getExportedUrls() {
return urls;
}
diff --git a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/ServiceConfigTest.java b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/ServiceConfigTest.java
index 5da2b46..74c1c92 100644
--- a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/ServiceConfigTest.java
+++ b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/ServiceConfigTest.java
@@ -194,6 +194,18 @@ public class ServiceConfigTest {
service.setGeneric("illegal");
}
+ @Test(expected = IllegalArgumentException.class)
+ public void testMock() throws Exception {
+ ServiceConfig service = new ServiceConfig();
+ service.setMock("true");
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void testMock2() throws Exception {
+ ServiceConfig service = new ServiceConfig();
+ service.setMock(true);
+ }
+
@Test
public void testUniqueServiceName() throws Exception {
ServiceConfig<Greeting> service = new ServiceConfig<Greeting>();