You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/02 11:27:54 UTC

[GitHub] [skywalking] kezhenxu94 opened a new pull request #4162: Support collecting http parameters

kezhenxu94 opened a new pull request #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162
 
 
   Plugins of Tomcat, Spring MVC, Armeria are supported for now
   
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   This pull request provides another config item to enable/disable collecting http parameters of a request.
   
   It uses a general name `plugin.http.collect_http_params` but doesn't guarantee that all http plugins should be under its control, unless the plugin itself takes this config item into consideration, such as Tomcat, Spring MVC, and Armeria plugin.
   
   This pull request also partially close #324 but I would suggest open another issue to track the downstreaming config feature, and I believe we need more discussion on that, @wu-sheng 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570198164
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=h1) Report
   > Merging [#4162](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4012545ed44e7098b653ec01e3309adc7fd3f941?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `6.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4162/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4162      +/-   ##
   ==========================================
   - Coverage   26.86%   26.83%   -0.03%     
   ==========================================
     Files        1160     1161       +1     
     Lines       25381    25409      +28     
     Branches     3682     3689       +7     
   ==========================================
   + Hits         6818     6819       +1     
   - Misses      17955    17981      +26     
   - Partials      608      609       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0% <0%> (ø)` | |
   | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `68% <0%> (-2.84%)` | :arrow_down: |
   | [...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh) | `100% <100%> (ø)` | :arrow_up: |
   | [.../apm/plugin/tomcat78x/TomcatInvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdG9tY2F0LTcueC04LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vdG9tY2F0Nzh4L1RvbWNhdEludm9rZUludGVyY2VwdG9yLmphdmE=) | `58.97% <7.14%> (-29.49%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=footer). Last update [4012545...6884f86](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] dmsolr commented on a change in pull request #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#discussion_r362445292
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/util/CollectionUtil.java
 ##########
 @@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.apm.agent.core.util;
+
+import java.util.Arrays;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+/**
+ * Some utility methods for collections.
+ * Reinvent the wheels because importing third-party libs just for some methods is not worthwhile in agent side
+ *
+ * @author kezhenxu94
+ * @since 7.0.0
+ */
+public final class CollectionUtil {
+    public static String toString(final Map<String, String[]> map) {
+        return map
+            .entrySet()
+            .parallelStream()
 
 Review comment:
   As far as I know, `parallelStream()` could cause high latency on high requests. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 merged pull request #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570200454
 
 
   And is running on my test environment now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#discussion_r362475668
 
 

 ##########
 File path: test/plugin/scenarios/spring-3.1.x-scenario/src/main/webapp/WEB-INF/web.xml
 ##########
 @@ -23,6 +23,20 @@
          version="3.1">
     <display-name>skywalking-spring-3.1.x-scenario</display-name>
 
+    <filter>
+        <filter-name>setCharacterEncodingFilter</filter-name>
+        <filter-class>org.apache.catalina.filters.SetCharacterEncodingFilter</filter-class>
+        <init-param>
+            <param-name>encoding</param-name>
+            <param-value>GBK</param-value>
+        </init-param>
+    </filter>
+
+    <filter-mapping>
+        <filter-name>setCharacterEncodingFilter</filter-name>
+        <url-pattern>/*</url-pattern>
+    </filter-mapping>
+
 
 Review comment:
   @wu-sheng Here I meant

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570198164
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=h1) Report
   > Merging [#4162](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/5fba91901fe90865e2ad751d36e90a9fa2c70b7c?src=pr&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `6.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4162/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4162      +/-   ##
   ==========================================
   + Coverage   26.81%   26.84%   +0.02%     
   ==========================================
     Files        1160     1161       +1     
     Lines       25381    25405      +24     
     Branches     3682     3687       +5     
   ==========================================
   + Hits         6806     6819      +13     
   - Misses      17970    17978       +8     
   - Partials      605      608       +3
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `68% <0%> (-2.84%)` | :arrow_down: |
   | [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0% <0%> (ø)` | |
   | [...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh) | `100% <100%> (ø)` | :arrow_up: |
   | [.../apm/plugin/tomcat78x/TomcatInvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdG9tY2F0LTcueC04LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vdG9tY2F0Nzh4L1RvbWNhdEludm9rZUludGVyY2VwdG9yLmphdmE=) | `58.97% <7.14%> (-29.49%)` | :arrow_down: |
   | [...ion/consul/ConsulConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWNvbnN1bC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vY29uc3VsL0NvbnN1bENvbmZpZ3VyYXRpb25XYXRjaGVyUmVnaXN0ZXIuamF2YQ==) | `54% <0%> (+2.07%)` | :arrow_up: |
   | [...ter/plugin/consul/ClusterModuleConsulProvider.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1jb25zdWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY2x1c3Rlci9wbHVnaW4vY29uc3VsL0NsdXN0ZXJNb2R1bGVDb25zdWxQcm92aWRlci5qYXZh) | `100% <0%> (+7.14%)` | :arrow_up: |
   | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (+13.48%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=footer). Last update [5fba919...bae29cd](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#discussion_r362508789
 
 

 ##########
 File path: test/plugin/scenarios/spring-3.1.x-scenario/src/main/webapp/WEB-INF/web.xml
 ##########
 @@ -23,6 +23,20 @@
          version="3.1">
     <display-name>skywalking-spring-3.1.x-scenario</display-name>
 
+    <filter>
+        <filter-name>setCharacterEncodingFilter</filter-name>
+        <filter-class>org.apache.catalina.filters.SetCharacterEncodingFilter</filter-class>
+        <init-param>
+            <param-name>encoding</param-name>
+            <param-value>GBK</param-value>
+        </init-param>
+    </filter>
+
+    <filter-mapping>
+        <filter-name>setCharacterEncodingFilter</filter-name>
+        <url-pattern>/*</url-pattern>
+    </filter-mapping>
+
 
 Review comment:
   Got it. Do we need to revert back? I don't want the GBK is a good example :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#discussion_r362465285
 
 

 ##########
 File path: docs/en/setup/service-agent/java-agent/README.md
 ##########
 @@ -118,6 +118,8 @@ property key | Description | Default |
 `plugin.opgroup.*`|Support operation name customize group rules in different plugins. Read [Group rule supported plugins](op_name_group_rule.md)|Not set|
 `plugin.springtransaction.simplify_transaction_definition_name`|If true, the transaction definition name will be simplified.|false|
 `plugin.jdkthreading.threading_class_prefixes` | Threading classes (`java.lang.Runnable` and `java.util.concurrent.Callable`) and their subclasses, including anonymous inner classes whose name match any one of the `THREADING_CLASS_PREFIXES` (splitted by `,`) will be instrumented, make sure to only specify as narrow prefixes as what you're expecting to instrument, (`java.` and `javax.` will be ignored due to safety issues) | Not set |
+`plugin.http.collect_http_params`| This config item controls that whether the plugins related to HTTP should collect the parameters of the request. The name `plugin.http.collect_http_params` is rather general, but it doesn't guarantee that all http plugins should be under its control, unless the plugin itself takes this config item into consideration, such as Tomcat, Spring MVC, and Armeria plugin. | `false` |
 
 Review comment:
   Do we need to indicate this should work for UTF-8 encoding project? I think some vendors are using GBK in telecom, bank, etic

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570198164
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=h1) Report
   > Merging [#4162](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7902c6242fca7cc66d6f6d1858711a3b3fa7594e?src=pr&el=desc) will **decrease** coverage by `0.02%`.
   > The diff coverage is `6.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4162/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4162      +/-   ##
   ==========================================
   - Coverage   26.86%   26.83%   -0.03%     
   ==========================================
     Files        1160     1161       +1     
     Lines       25381    25409      +28     
     Branches     3682     3689       +7     
   ==========================================
   + Hits         6818     6819       +1     
   - Misses      17955    17981      +26     
   - Partials      608      609       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `68% <0%> (-2.84%)` | :arrow_down: |
   | [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0% <0%> (ø)` | |
   | [...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh) | `100% <100%> (ø)` | :arrow_up: |
   | [.../apm/plugin/tomcat78x/TomcatInvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdG9tY2F0LTcueC04LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vdG9tY2F0Nzh4L1RvbWNhdEludm9rZUludGVyY2VwdG9yLmphdmE=) | `58.97% <7.14%> (-29.49%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=footer). Last update [7902c62...728d69f](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#discussion_r362475195
 
 

 ##########
 File path: docs/en/setup/service-agent/java-agent/README.md
 ##########
 @@ -118,6 +118,8 @@ property key | Description | Default |
 `plugin.opgroup.*`|Support operation name customize group rules in different plugins. Read [Group rule supported plugins](op_name_group_rule.md)|Not set|
 `plugin.springtransaction.simplify_transaction_definition_name`|If true, the transaction definition name will be simplified.|false|
 `plugin.jdkthreading.threading_class_prefixes` | Threading classes (`java.lang.Runnable` and `java.util.concurrent.Callable`) and their subclasses, including anonymous inner classes whose name match any one of the `THREADING_CLASS_PREFIXES` (splitted by `,`) will be instrumented, make sure to only specify as narrow prefixes as what you're expecting to instrument, (`java.` and `javax.` will be ignored due to safety issues) | Not set |
+`plugin.http.collect_http_params`| This config item controls that whether the plugins related to HTTP should collect the parameters of the request. The name `plugin.http.collect_http_params` is rather general, but it doesn't guarantee that all http plugins should be under its control, unless the plugin itself takes this config item into consideration, such as Tomcat, Spring MVC, and Armeria plugin. | `false` |
 
 Review comment:
   > Do we need to indicate this should work for UTF-8 encoding project? I think some vendors are using GBK in telecom, bank, etic
   
   I've modified the case to specify the encoding as GBK, and it works, still

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570198164
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=h1) Report
   > Merging [#4162](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7902c6242fca7cc66d6f6d1858711a3b3fa7594e?src=pr&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `6.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4162/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4162      +/-   ##
   ==========================================
   - Coverage   26.86%   26.78%   -0.08%     
   ==========================================
     Files        1160     1161       +1     
     Lines       25381    25409      +28     
     Branches     3682     3689       +7     
   ==========================================
   - Hits         6818     6807      -11     
   - Misses      17955    17996      +41     
   + Partials      608      606       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0% <0%> (ø)` | |
   | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `68% <0%> (-2.84%)` | :arrow_down: |
   | [...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh) | `100% <100%> (ø)` | :arrow_up: |
   | [.../apm/plugin/tomcat78x/TomcatInvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdG9tY2F0LTcueC04LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vdG9tY2F0Nzh4L1RvbWNhdEludm9rZUludGVyY2VwdG9yLmphdmE=) | `58.97% <7.14%> (-29.49%)` | :arrow_down: |
   | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (-13.49%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=footer). Last update [7902c62...728d69f](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570198164
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@ad47d60`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4162/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4162   +/-   ##
   =========================================
     Coverage          ?   26.83%           
   =========================================
     Files             ?     1161           
     Lines             ?    25409           
     Branches          ?     3689           
   =========================================
     Hits              ?     6819           
     Misses            ?    17981           
     Partials          ?      609
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=footer). Last update [ad47d60...728d69f](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570198598
 
 
   > Why change Tomcat plugin rather than changing SpringMVC plugin? It should be more adaptive?
   
   Is it possible to assume that all http services are based on SpringMVC? Armeria is an apparent exception, and that's why we have Tomcat plugin and Spring MVC plugin now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570199055
 
 
   I am not sure whether Tomcat plugin will face the parameter encoding issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#discussion_r362513773
 
 

 ##########
 File path: test/plugin/scenarios/spring-3.1.x-scenario/src/main/webapp/WEB-INF/web.xml
 ##########
 @@ -23,6 +23,20 @@
          version="3.1">
     <display-name>skywalking-spring-3.1.x-scenario</display-name>
 
+    <filter>
+        <filter-name>setCharacterEncodingFilter</filter-name>
+        <filter-class>org.apache.catalina.filters.SetCharacterEncodingFilter</filter-class>
+        <init-param>
+            <param-name>encoding</param-name>
+            <param-value>GBK</param-value>
+        </init-param>
+    </filter>
+
+    <filter-mapping>
+        <filter-name>setCharacterEncodingFilter</filter-name>
+        <url-pattern>/*</url-pattern>
+    </filter-mapping>
+
 
 Review comment:
   > Got it. Do we need to revert back? I don't want the GBK is a good example :)
   
   I’m ok with both situations, will revert it 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570198164
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=h1) Report
   > Merging [#4162](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/5fba91901fe90865e2ad751d36e90a9fa2c70b7c?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `6.89%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4162/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4162      +/-   ##
   ==========================================
   + Coverage   26.86%   26.87%   +<.01%     
   ==========================================
     Files        1160     1161       +1     
     Lines       25381    25409      +28     
     Branches     3682     3689       +7     
   ==========================================
   + Hits         6818     6828      +10     
   - Misses      17955    17973      +18     
     Partials      608      608
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...commons/interceptor/AbstractMethodInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tY29tbW9ucy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvY29tbW9ucy9pbnRlcmNlcHRvci9BYnN0cmFjdE1ldGhvZEludGVyY2VwdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...skywalking/apm/agent/core/util/CollectionUtil.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9Db2xsZWN0aW9uVXRpbC5qYXZh) | `0% <0%> (ø)` | |
   | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `68% <0%> (-2.84%)` | :arrow_down: |
   | [...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh) | `100% <100%> (ø)` | :arrow_up: |
   | [.../apm/plugin/tomcat78x/TomcatInvokeInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vdG9tY2F0LTcueC04LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vdG9tY2F0Nzh4L1RvbWNhdEludm9rZUludGVyY2VwdG9yLmphdmE=) | `58.97% <7.14%> (-29.49%)` | :arrow_down: |
   | [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `61.26% <0%> (+0.9%)` | :arrow_up: |
   | [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `47.19% <0%> (+2.24%)` | :arrow_up: |
   | [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4162/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `54.16% <0%> (+25%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=footer). Last update [5fba919...bae29cd](https://codecov.io/gh/apache/skywalking/pull/4162?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
kezhenxu94 removed a comment on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570200454
 
 
   And is running on my test environment now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on issue #4162: Support collecting http parameters

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4162: Support collecting http parameters
URL: https://github.com/apache/skywalking/pull/4162#issuecomment-570200056
 
 
   > I am not sure whether Tomcat plugin will face the parameter encoding issue.
   
   Yes sadly, I've suffered from that, and that's why the codes to get parameter map in Tomcat plugin is more complicated than those in Spring MVC's, at least I've tested and the plugin test codes show that.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services