You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@click.apache.org by "Naoki Takezoe (Commented) (JIRA)" <ji...@apache.org> on 2012/04/03 19:30:25 UTC
[jira] [Commented] (CLK-778) EmailField Data Validation Is
Insufficient
[ https://issues.apache.org/jira/browse/CLK-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245526#comment-13245526 ]
Naoki Takezoe commented on CLK-778:
-----------------------------------
I think it should be fixed, but it might break backward compatibility.
I can't judge whether we should do it.
How do you think about it?
> EmailField Data Validation Is Insufficient
> ------------------------------------------
>
> Key: CLK-778
> URL: https://issues.apache.org/jira/browse/CLK-778
> Project: Click
> Issue Type: Bug
> Components: extras
> Reporter: Clint Lawrence
> Assignee: Naoki Takezoe
>
> In the Click Extras project, the current EmailField validation does not sufficiently limit user input to the format of an email address. As an example, I loaded the Avoka examples site and was able to successfully submit the following as an email address in the Extra Form Controls page:
> how.can@this@be@a@valid.email.address
> For my own use I have extended EmailField with the following additional validation logic:
> private static final Pattern EMAIL_ADDRESS_REGEX_PATTERN = Pattern.compile("^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\\.[a-zA-Z]{2,4}$", Pattern.CASE_INSENSITIVE);
> ...
> @Override
> public void validate() {
> super.validate();
> if (EMAIL_ADDRESS_REGEX_PATTERN.matcher(StringUtils.trimToEmpty(this.value)).matches())
> {
> this.setErrorMessage("email-format-error");
> }
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira