You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/05/18 01:45:29 UTC
[GitHub] [netbeans] pepness opened a new pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
pepness opened a new pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963
Notes:
- Reduced size of jaxrs/jersey library by 21%
| Directory | Size before | Size after |
| --------------- | --------------- | --------------- |
| jaxrs-2.0/jaxrs-2.1 | 0.1128 MB | 0.1404 MB |
| jersey2 | 6.1 MB | 4.8 MB |
| Total | 6.2128 MB | 4.9404 MB |
- Utilize jakarta libraries instead of javax
- Add new license EPL-v20-GPL-2-CP
- Update license type to EPL-v20-GPL-2-CP where needed
- Upgrade hk2 from 2.2 to 2.6.1
-- Add aopalliance-repackaged dependency
-- Remove cglib dependency
-- Remove asm-all-repackaged dependency (2.5.0-b64)
- Upgrade jersey from 2.5.1 to 2.34
-- Remove guava dependency
- Use one license file for all jersey libraries and use license type EPL-v20
- Upgrade versions inside Bundle.properties file
- Fix validation inside ignored-overlaps file
- Use one license file for hk2 dependencies
Testing:
- Full build done
- Verify successful execution of unit tests for module `websvc.restlib`
- Checked the files are in the Ant Library Manager
- Successfully create project as per [Jersey documentation](https://eclipse-ee4j.github.io/jersey.github.io/documentation/latest/getting-started.html), with Apache Tomcat and TomEE
- Ant based project based on Jersey documentation in https://github.com/pepness/jerseyapp
- Successfully create project as per [NetBeans Documentation](https://netbeans.apache.org/kb/docs/websvc/rest.html), with Payara and Glassfish
- Successfully create project as per [Oracle Documentation](https://www.oracle.com/webfolder/technetwork/tutorials/obe/java/RESTfulWebServices/RESTfulWebservices.htm), with Payara and Glassfish
Problems:
- Failed execution of `ant verify-libs-and-licenses` for 6 jars with error `has a GPL-family license but is either not covered by the Classpath Exception, or is not compile-time/optional only`.
I need help with this, I do not know what is wrong. Theses are the jars and license type of each one of the 6 errors:
1. [hk2 license](https://github.com/eclipse-ee4j/glassfish-hk2/blob/master/LICENSE.md)
- Inside the jar/MANIFEST.MF Bundle-License: http://www.eclipse.org/legal/epl-2.0, https://www.gnu.org/software/classpath/license.html
2. [jakarta.annotation-api](https://github.com/eclipse-ee4j/common-annotations-api/blob/master/LICENSE.md)
- Inside the jar/MANIFEST.MF Bundle-License: http://www.eclipse.org/legal/epl-2.0, https://www.gnu.org/software/classpath/license.html
3. [jakarta.persistence-api](https://github.com/eclipse-ee4j/jpa-api)
- Inside the jar/MANIFEST.MF Bundle-License: http://www.eclipse.org/legal/epl-2.0, http://www.eclipse.org/org/documents/edl-v10.php
4. [jakarta.servlet-api](https://github.com/eclipse-ee4j/servlet-api/blob/master/LICENSE.md)
- Inside the jar/MANIFEST.MF Bundle-License: http://www.eclipse.org/legal/epl-2.0, https://www.gnu.org/software/classpath/license.html
5. [jakarta.ws.rs-api](https://github.com/eclipse-ee4j/jaxrs-api/blob/master/LICENSE.md)
- Inside the jar/MANIFEST.MF Bundle-License: http://www.eclipse.org/legal/epl-2.0, https://www.gnu.org/software/classpath/license.html
6. [jakarta.xml.bind-api](https://github.com/eclipse-ee4j/jaxb-api)
- Inside the jar/MANIFEST.MF Bundle-License: http://www.eclipse.org/legal/epl-2.0, https://www.gnu.org/software/classpath/license.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#issuecomment-872959254
@pepness I think so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#issuecomment-864631580
Travis failed because of timeouts but I think is ready to be merged. Can someone have a look? @ebarboni @matthiasblaesing @sdedic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#issuecomment-873473153
Should I squash the commits @ebarboni?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on a change in pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
pepness commented on a change in pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#discussion_r658328565
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
##########
@@ -45,14 +45,19 @@ nbbuild/external/json-simple-1.1.1.jar ide/libs.json_simple/external/json-simple
webcommon/javascript2.jade/external/jflex-1.4.3.jar webcommon/javascript2.lexer/external/jflex-1.4.3.jar
# javax.annotation-api is used by multiple modules.
-enterprise/websvc.restlib/external/javax.annotation-api-1.2.jar java/maven.indexer/external/javax.annotation-api-1.2.jar
enterprise/javaee.api/external/javax.annotation-api-1.2.jar java/maven.indexer/external/javax.annotation-api-1.2.jar
Review comment:
I upgraded the javax.annotation-api only inside the `enterprise.websvc` module. In [PR-1809](https://github.com/apache/netbeans/pull/1809) Matthias Bläsing stated that I should only use the versions that belong to each release of JavaEE. I think in this case I should create another PR to upgrade the version of javax.annotation-api for the modules `enterprise/javaee8.api` to javax.annotation-api:1.3.2 and `java/maven.indexer` to jakarta.annotation-api:1.3.5. I hope I understood your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jGauravGupta commented on pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
jGauravGupta commented on pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#issuecomment-867925231
+1 LGTM, Tested Maven/Ant application on Payara and GlassFish Server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] pepness commented on pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
pepness commented on pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#issuecomment-872605927
Can this make it to 12.5 @ebarboni?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jGauravGupta commented on a change in pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
jGauravGupta commented on a change in pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#discussion_r658256534
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
##########
@@ -45,14 +45,19 @@ nbbuild/external/json-simple-1.1.1.jar ide/libs.json_simple/external/json-simple
webcommon/javascript2.jade/external/jflex-1.4.3.jar webcommon/javascript2.lexer/external/jflex-1.4.3.jar
# javax.annotation-api is used by multiple modules.
-enterprise/websvc.restlib/external/javax.annotation-api-1.2.jar java/maven.indexer/external/javax.annotation-api-1.2.jar
enterprise/javaee.api/external/javax.annotation-api-1.2.jar java/maven.indexer/external/javax.annotation-api-1.2.jar
Review comment:
javax.annotation-api-1.2 upgrade to jakarta.annotation-api:1.3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#issuecomment-865092341
seems ok rerun is sometimes working :D. maybe @jGauravGupta as I saw payara may help reviewing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#issuecomment-874775972
I would say yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2963: [NETBEANS-5686] Upgrade module 'websvc.restlib' libraries
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2963:
URL: https://github.com/apache/netbeans/pull/2963#issuecomment-865092341
seems ok rerun is sometimes working :D. maybe @jGauravGupta as I saw payara may help reviewing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists