You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by shimamoto <gi...@git.apache.org> on 2017/05/11 11:10:26 UTC
[GitHub] incubator-predictionio pull request #382: [PIO-64] Fixed a bug that JDBCPEve...
GitHub user shimamoto opened a pull request:
https://github.com/apache/incubator-predictionio/pull/382
[PIO-64] Fixed a bug that JDBCPEvents unit tests fail intermittently
Revert the following commit which is the cause of the error:
https://github.com/apache/incubator-predictionio/commit/be3611d9d00625975f1f64de4cc6c1c829d8f542
For more information, see [here](https://issues.apache.org/jira/browse/PIO-64?focusedCommentId=16004227&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16004227).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shimamoto/incubator-predictionio pio-64_unit-tests-fail
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #382
----
commit b623fb0b8c4bf6113c99564bd4d0d675f1526e05
Author: shimamoto <ch...@gmail.com>
Date: 2017-05-10T11:14:47Z
[PIO-64] Fixed a bug that JDBCPEvents unit tests fail intermittently.
Revert the following commit which is the cause of the error:
https://github.com/apache/incubator-predictionio/commit/be3611d9d00625975f1f64de4cc6c1c829d8f542
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #382: [PIO-64] Fixed a bug that JDBCPEvents uni...
Posted by shimamoto <gi...@git.apache.org>.
Github user shimamoto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/382
@EmergentOrder Thanks for review. I’m glad things worked out fine :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #382: [PIO-64] Fixed a bug that JDBCPEvents uni...
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/382
Hey @emergentorder, do you have a chance to take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #382: [PIO-64] Fixed a bug that JDBCPEvents uni...
Posted by EmergentOrder <gi...@git.apache.org>.
Github user EmergentOrder commented on the issue:
https://github.com/apache/incubator-predictionio/pull/382
This change looks good to me. Agree that it is wrong to set creation time to event time, and this should bring behavior back in line with that of HBase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #382: [PIO-64] Fixed a bug that JDBCPEve...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/382
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---