You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/07/18 12:18:27 UTC

[GitHub] [bookkeeper] rudy2steiner opened a new pull request #2380: NP check for print BookieSocketAddress and a better format

rudy2steiner opened a new pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380


   Descriptions of the changes in this PR:
   
   
   
   ### Motivation
   
   NP check for print BookieSocketAddress and a better format to fix issues #2376 and #2371
   
   ### Changes
   * NP check for print BookieSocketAddress on listbookies command
   * A better format mentioned on #2376 
   
   Master Issue: #2376 #2371 
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] mikecaat commented on pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
mikecaat commented on pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380#issuecomment-660484358


   @rudy2steiner 
   Thanks for making a patch!
   I think it's better to change its test code.
   
   Since it's related to this fix, why don't you fix the dependencies of the doc and the source code?
   Let me know if I should make another pull request for this change. It's ok.
   https://github.com/mikecaat/bookkeeper/commit/3c1123a62e00f558d9c4fb5518ad38a7c44908f2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] rudy2steiner commented on pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380#issuecomment-660474914


   @mikecaat @sntfrc @sijie 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] rudy2steiner edited a comment on pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
rudy2steiner edited a comment on pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380#issuecomment-660495903


   @eolivelli  I just mix an unknown hostname on bookieids, if none of the tests will be failed, proving that we can handle unknown hostname in bookieid gracefully. is this ok?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] rudy2steiner commented on pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380#issuecomment-660490499


   @eolivelli you mean to add a test case for an invalid hostname in BookieSocketAdress instance?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] mikecaat edited a comment on pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
mikecaat edited a comment on pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380#issuecomment-660484358


   @rudy2steiner 
   Thanks for making a patch!
   I think it's better to change its test code too.
   
   Since it's related to this fix, why don't you fix the dependencies of the doc and the source code?
   Let me know if I should make another pull request for this change. It's ok.
   https://github.com/mikecaat/bookkeeper/commit/3c1123a62e00f558d9c4fb5518ad38a7c44908f2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] rudy2steiner commented on pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380#issuecomment-660492500


   @mikecaat  you may continue your pr, this pr don't change the command input, it just wants to handle some exception 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] rudy2steiner commented on pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380#issuecomment-660495903


   @eolivelli  I just mix an unknown hostname on bookieids, if none of the tests will be failed, proving that we can handle unknown hostname in bookieid gracefully.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] sijie merged pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] mikecaat edited a comment on pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
mikecaat edited a comment on pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380#issuecomment-660484358


   @rudy2steiner 
   Thanks for making a patch!
   I think it's better to change its test code too.
   
   Since it's related to this fix, why don't you fix the dependencies of the doc and the source code?
   Let me know if I should make another pull request for this change. It's ok.
   https://github.com/mikecaat/bookkeeper/commit/f63c4f770fc72b674f87e272e439e067a9cdef17


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] rudy2steiner edited a comment on pull request #2380: NP check for print BookieSocketAddress and a better format

Posted by GitBox <gi...@apache.org>.
rudy2steiner edited a comment on pull request #2380:
URL: https://github.com/apache/bookkeeper/pull/2380#issuecomment-660490499


   @eolivelli you mean to add a test case for an invalid hostname in bookieId?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org