You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/02 18:21:24 UTC

Review Request 12233: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42 (Stable master Patch)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12233/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.


Bugs: CLOUDSTACK-3324


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42

During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors 


Diffs
-----

  engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 90a311b 

Diff: https://reviews.apache.org/r/12233/diff/


Testing
-------

Tested locally


Thanks,

Harikrishna Patnala


Re: Review Request 12233: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42 (Stable master Patch)

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12233/#review23489
-----------------------------------------------------------


Commit 85e32552a33bc93d00bdfc9297fad5daac7f0a27 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=85e3255 ]

CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On July 2, 2013, 4:21 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12233/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 4:21 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3324
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42
> 
> During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors 
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 90a311b 
> 
> Diff: https://reviews.apache.org/r/12233/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12233: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42 (Stable master Patch)

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12233/#review22711
-----------------------------------------------------------


Commit f9270304e00633a30f6954acd36aaeb0f2907f98 in branch refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f927030 ]

CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On July 2, 2013, 4:21 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12233/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 4:21 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3324
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42
> 
> During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors 
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 90a311b 
> 
> Diff: https://reviews.apache.org/r/12233/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12233: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42 (Stable master Patch)

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12233/#review22712
-----------------------------------------------------------


Commit e63ac5512e85217274a63996ee1e14f887c45dae in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e63ac55 ]

CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On July 2, 2013, 4:21 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12233/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 4:21 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3324
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42
> 
> During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors 
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 90a311b 
> 
> Diff: https://reviews.apache.org/r/12233/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12233: CLOUDSTACK-3324: Fix/Improve upgrade system vm templates 41 to 42 (Stable master Patch)

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12233/#review22710
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On July 2, 2013, 4:21 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12233/
> -----------------------------------------------------------
> 
> (Updated July 2, 2013, 4:21 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-3324
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3324: Fix/Improve upgrade system vm template 41 to 42
> 
> During upgrade system vm template from 4.1 to 4.2 there are case sensitive checks happening which needs to be fixed and improve by generalizing the code for all hypervisors 
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 90a311b 
> 
> Diff: https://reviews.apache.org/r/12233/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>