You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/12 18:05:22 UTC
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6652: fix: handle no_used_column Window push_down_projection
alamb commented on code in PR #6652:
URL: https://github.com/apache/arrow-datafusion/pull/6652#discussion_r1227054891
##########
datafusion/core/tests/sqllogictests/test_files/window.slt:
##########
@@ -258,34 +258,37 @@ Sort: d.b ASC NULLS LAST
----Aggregate: groupBy=[[d.b]], aggr=[[MAX(d.a)]]
------SubqueryAlias: d
--------SubqueryAlias: _data2
-----------SubqueryAlias: s
-------------SubqueryAlias: _sample_data
Review Comment:
Isn't the new plan worse? Previously there is no `WindowAggr` because `seq is not used in the outer query's select list:
```sql
SELECT d.b, MAX(d.a) AS max_a
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org