You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/05 02:42:49 UTC
[GitHub] [iotdb] CRZbulabula opened a new pull request, #6899: [IOTDB-3845] Add annotations in confignode.thrift
CRZbulabula opened a new pull request, #6899:
URL: https://github.com/apache/iotdb/pull/6899
Ad interface annotation in confignode.thrift file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #6899: [IOTDB-3845] Add annotations in confignode.thrift
Posted by GitBox <gi...@apache.org>.
CRZbulabula commented on code in PR #6899:
URL: https://github.com/apache/iotdb/pull/6899#discussion_r938421216
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/ClusterSchemaManager.java:
##########
@@ -354,25 +354,15 @@ public TGetAllTemplatesResp getAllTemplates() {
resp.setStatus(templateResp.getStatus());
if (resp.getStatus().getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
if (templateResp.getTemplateList() != null) {
- List<ByteBuffer> list = new ArrayList<ByteBuffer>();
- templateResp
- .getTemplateList()
- .forEach(
- template -> {
- list.add(template.serialize());
- });
+ List<ByteBuffer> list = new ArrayList<>();
+ templateResp.getTemplateList().forEach(template -> list.add(template.serialize()));
resp.setTemplateList(list);
}
}
return resp;
}
- /**
- * show nodes in schema template
- *
- * @param req
- * @return
- */
+ /** show nodes in schema template */
Review Comment:
But this annotation doesn't interprete the meaning of parameter and return value. I've left TODO for the relevant schoolmates and hope they'll add more detailed instructions later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] qiaojialin merged pull request #6899: [IOTDB-3845] Add annotations in confignode.thrift
Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #6899:
URL: https://github.com/apache/iotdb/pull/6899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a diff in pull request #6899: [IOTDB-3845] Add annotations in confignode.thrift
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on code in PR #6899:
URL: https://github.com/apache/iotdb/pull/6899#discussion_r938411358
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/ClusterSchemaManager.java:
##########
@@ -354,25 +354,15 @@ public TGetAllTemplatesResp getAllTemplates() {
resp.setStatus(templateResp.getStatus());
if (resp.getStatus().getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
if (templateResp.getTemplateList() != null) {
- List<ByteBuffer> list = new ArrayList<ByteBuffer>();
- templateResp
- .getTemplateList()
- .forEach(
- template -> {
- list.add(template.serialize());
- });
+ List<ByteBuffer> list = new ArrayList<>();
+ templateResp.getTemplateList().forEach(template -> list.add(template.serialize()));
resp.setTemplateList(list);
}
}
return resp;
}
- /**
- * show nodes in schema template
- *
- * @param req
- * @return
- */
+ /** show nodes in schema template */
Review Comment:
why ? Generally, comments must contain parameter and return value descriptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org