You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/13 19:35:30 UTC
[GitHub] [beam] csteegz opened a new pull request, #23217: Exclude insignificant whitespace from cloud object
csteegz opened a new pull request, #23217:
URL: https://github.com/apache/beam/pull/23217
Schema coders in cloud schema currently have a JSON representation of the schema. By excluding insignificant whitespace, we reduce the amount of space that the JSON representation uses on disk.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23217: Exclude insignificant whitespace from cloud object
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23217:
URL: https://github.com/apache/beam/pull/23217#issuecomment-1245873780
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] steveniemitz merged pull request #23217: Exclude insignificant whitespace from cloud object
Posted by GitBox <gi...@apache.org>.
steveniemitz merged PR #23217:
URL: https://github.com/apache/beam/pull/23217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] csteegz commented on pull request #23217: Exclude insignificant whitespace from cloud object
Posted by GitBox <gi...@apache.org>.
csteegz commented on PR #23217:
URL: https://github.com/apache/beam/pull/23217#issuecomment-1245936415
It's going to depend on the nesting of the schema, use of options etc and length of the field names, but I'd expect a decent amount.
The JSON representation of a large pipeline I have that extensively utilizes schemas went from ~18.7 MB to ~14.2 MB on disc when I manually stripped whitespace characters. While I'm guessing they compress well, this change should save some storage, and depending on how the validation works might let some more pipelines be run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] steveniemitz commented on pull request #23217: Exclude insignificant whitespace from cloud object
Posted by GitBox <gi...@apache.org>.
steveniemitz commented on PR #23217:
URL: https://github.com/apache/beam/pull/23217#issuecomment-1245913538
any idea of the space savings from this?
`./gradlew spotlessJavaApply` to fix the formatting errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] csteegz commented on pull request #23217: Exclude insignificant whitespace from cloud object
Posted by GitBox <gi...@apache.org>.
csteegz commented on PR #23217:
URL: https://github.com/apache/beam/pull/23217#issuecomment-1245872790
R: @steveniemitz
R: @reuvenlax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org