You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Yakov Markovitch (JIRA)" <ji...@apache.org> on 2012/11/30 20:01:58 UTC
[jira] [Created] (TS-1606) Log buffers are not flushed periodically
when TS is launched with NO_REMOTE_MANAGEMENT flag
Yakov Markovitch created TS-1606:
------------------------------------
Summary: Log buffers are not flushed periodically when TS is launched with NO_REMOTE_MANAGEMENT flag
Key: TS-1606
URL: https://issues.apache.org/jira/browse/TS-1606
Project: Traffic Server
Issue Type: Bug
Components: Logging
Reporter: Yakov Markovitch
When TS binary is launched with NO_REMOTE_MANAGEMENT flag (e.g., when launched not as a daemon but directly - this is extremely convenient for debugging), the PeriodicWakeup event is not scheduled.
As a result, Log::flush_thread_main() does not wake up periodically, but only on log buffer overflow. Coupled with a horribly wrong activation check in Log::flush_thread_main():
{code}
if (now > last_time) {
if ((now % PERIODIC_TASKS_INTERVAL) == 0) {
// We run only when waken up at the moment which is exact
// multiple of PERIODIC_TASKS_INTERVAL!
{code}
this leads to that probability of any log output is low.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1606) Log buffers are not flushed periodically
when TS is launched with NO_REMOTE_MANAGEMENT flag
Posted by "Yakov Markovitch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yakov Markovitch updated TS-1606:
---------------------------------
Attachment: trafficserver-periodic-tasks.patch
This patch both fixes the bug and removes some dead code in logging initialization.
> Log buffers are not flushed periodically when TS is launched with NO_REMOTE_MANAGEMENT flag
> -------------------------------------------------------------------------------------------
>
> Key: TS-1606
> URL: https://issues.apache.org/jira/browse/TS-1606
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Affects Versions: 3.3.0, 3.2.0
> Reporter: Yakov Markovitch
> Attachments: trafficserver-periodic-tasks.patch
>
>
> When TS binary is launched with NO_REMOTE_MANAGEMENT flag (e.g., when launched not as a daemon but directly - this is extremely convenient for debugging), the PeriodicWakeup event is not scheduled.
> As a result, Log::flush_thread_main() does not wake up periodically, but only on log buffer overflow. Coupled with a horribly wrong activation check in Log::flush_thread_main():
> {code}
> if (now > last_time) {
> if ((now % PERIODIC_TASKS_INTERVAL) == 0) {
> // We run only when waken up at the moment which is exact
> // multiple of PERIODIC_TASKS_INTERVAL!
> {code}
> this leads to that probability of any log output is low.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1606) Log buffers are not flushed periodically
when TS is launched with NO_REMOTE_MANAGEMENT flag
Posted by "Yakov Markovitch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yakov Markovitch updated TS-1606:
---------------------------------
Attachment: (was: trafficserver-periodic-tasks.patch)
> Log buffers are not flushed periodically when TS is launched with NO_REMOTE_MANAGEMENT flag
> -------------------------------------------------------------------------------------------
>
> Key: TS-1606
> URL: https://issues.apache.org/jira/browse/TS-1606
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Affects Versions: 3.3.0, 3.2.0
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Fix For: 3.3.1
>
>
> When TS binary is launched with NO_REMOTE_MANAGEMENT flag (e.g., when launched not as a daemon but directly - this is extremely convenient for debugging), the PeriodicWakeup event is not scheduled.
> As a result, Log::flush_thread_main() does not wake up periodically, but only on log buffer overflow. Coupled with a horribly wrong activation check in Log::flush_thread_main():
> {code}
> if (now > last_time) {
> if ((now % PERIODIC_TASKS_INTERVAL) == 0) {
> // We run only when waken up at the moment which is exact
> // multiple of PERIODIC_TASKS_INTERVAL!
> {code}
> this leads to that probability of any log output is low.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1606) Log buffers are not flushed periodically
when TS is launched with NO_REMOTE_MANAGEMENT flag
Posted by "Yakov Markovitch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yakov Markovitch updated TS-1606:
---------------------------------
Affects Version/s: 3.3.0
3.2.0
> Log buffers are not flushed periodically when TS is launched with NO_REMOTE_MANAGEMENT flag
> -------------------------------------------------------------------------------------------
>
> Key: TS-1606
> URL: https://issues.apache.org/jira/browse/TS-1606
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Affects Versions: 3.3.0, 3.2.0
> Reporter: Yakov Markovitch
>
> When TS binary is launched with NO_REMOTE_MANAGEMENT flag (e.g., when launched not as a daemon but directly - this is extremely convenient for debugging), the PeriodicWakeup event is not scheduled.
> As a result, Log::flush_thread_main() does not wake up periodically, but only on log buffer overflow. Coupled with a horribly wrong activation check in Log::flush_thread_main():
> {code}
> if (now > last_time) {
> if ((now % PERIODIC_TASKS_INTERVAL) == 0) {
> // We run only when waken up at the moment which is exact
> // multiple of PERIODIC_TASKS_INTERVAL!
> {code}
> this leads to that probability of any log output is low.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1606) Log buffers are not flushed periodically
when TS is launched with NO_REMOTE_MANAGEMENT flag
Posted by "Yakov Markovitch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yakov Markovitch updated TS-1606:
---------------------------------
Attachment: trafficserver-periodic-tasks.patch
Better patch, prevents duplicate periodic tasks initialization.
> Log buffers are not flushed periodically when TS is launched with NO_REMOTE_MANAGEMENT flag
> -------------------------------------------------------------------------------------------
>
> Key: TS-1606
> URL: https://issues.apache.org/jira/browse/TS-1606
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Affects Versions: 3.3.0, 3.2.0
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Fix For: 3.3.1
>
> Attachments: trafficserver-periodic-tasks.patch
>
>
> When TS binary is launched with NO_REMOTE_MANAGEMENT flag (e.g., when launched not as a daemon but directly - this is extremely convenient for debugging), the PeriodicWakeup event is not scheduled.
> As a result, Log::flush_thread_main() does not wake up periodically, but only on log buffer overflow. Coupled with a horribly wrong activation check in Log::flush_thread_main():
> {code}
> if (now > last_time) {
> if ((now % PERIODIC_TASKS_INTERVAL) == 0) {
> // We run only when waken up at the moment which is exact
> // multiple of PERIODIC_TASKS_INTERVAL!
> {code}
> this leads to that probability of any log output is low.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1606) Log buffers are not flushed
periodically when TS is launched with NO_REMOTE_MANAGEMENT flag
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-1606:
---------------------------------
Assignee: Leif Hedstrom
> Log buffers are not flushed periodically when TS is launched with NO_REMOTE_MANAGEMENT flag
> -------------------------------------------------------------------------------------------
>
> Key: TS-1606
> URL: https://issues.apache.org/jira/browse/TS-1606
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Affects Versions: 3.3.0, 3.2.0
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Attachments: trafficserver-periodic-tasks.patch
>
>
> When TS binary is launched with NO_REMOTE_MANAGEMENT flag (e.g., when launched not as a daemon but directly - this is extremely convenient for debugging), the PeriodicWakeup event is not scheduled.
> As a result, Log::flush_thread_main() does not wake up periodically, but only on log buffer overflow. Coupled with a horribly wrong activation check in Log::flush_thread_main():
> {code}
> if (now > last_time) {
> if ((now % PERIODIC_TASKS_INTERVAL) == 0) {
> // We run only when waken up at the moment which is exact
> // multiple of PERIODIC_TASKS_INTERVAL!
> {code}
> this leads to that probability of any log output is low.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1606) Log buffers are not flushed periodically
when TS is launched with NO_REMOTE_MANAGEMENT flag
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-1606:
------------------------------
Fix Version/s: 3.3.1
> Log buffers are not flushed periodically when TS is launched with NO_REMOTE_MANAGEMENT flag
> -------------------------------------------------------------------------------------------
>
> Key: TS-1606
> URL: https://issues.apache.org/jira/browse/TS-1606
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Affects Versions: 3.3.0, 3.2.0
> Reporter: Yakov Markovitch
> Assignee: Leif Hedstrom
> Fix For: 3.3.1
>
> Attachments: trafficserver-periodic-tasks.patch
>
>
> When TS binary is launched with NO_REMOTE_MANAGEMENT flag (e.g., when launched not as a daemon but directly - this is extremely convenient for debugging), the PeriodicWakeup event is not scheduled.
> As a result, Log::flush_thread_main() does not wake up periodically, but only on log buffer overflow. Coupled with a horribly wrong activation check in Log::flush_thread_main():
> {code}
> if (now > last_time) {
> if ((now % PERIODIC_TASKS_INTERVAL) == 0) {
> // We run only when waken up at the moment which is exact
> // multiple of PERIODIC_TASKS_INTERVAL!
> {code}
> this leads to that probability of any log output is low.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira