You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/10 00:05:41 UTC

Review Request 13449: Fixed cgroups isolator to do setsid on the executor process.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13449/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Bugs: MESOS-636
    https://issues.apache.org/jira/browse/MESOS-636


Repository: mesos-git


Description
-------

Also, fixed some warnings related to OffersRescinded in slave recovery tests that were introduced in an earlier submitted review.


Diffs
-----

  src/slave/cgroups_isolator.cpp 3427c62416daced68f818feb60f194e00a68d94c 
  src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8 

Diff: https://reviews.apache.org/r/13449/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request 13449: Fixed cgroups isolator to do setsid on the executor process.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13449/#review24948
-----------------------------------------------------------

Ship it!



src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/13449/#comment49120>

    Process isolator? What's that? ;)
    
    Looks like this comment no longer applies in both the process isolator and here.


- Ben Mahler


On Aug. 9, 2013, 10:05 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13449/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 10:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-636
>     https://issues.apache.org/jira/browse/MESOS-636
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Also, fixed some warnings related to OffersRescinded in slave recovery tests that were introduced in an earlier submitted review.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolator.cpp 3427c62416daced68f818feb60f194e00a68d94c 
>   src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8 
> 
> Diff: https://reviews.apache.org/r/13449/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 13449: Fixed cgroups isolator to do setsid on the executor process.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13449/
-----------------------------------------------------------

(Updated Aug. 12, 2013, 1:10 a.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

benm and jie. NNFR.


Bugs: MESOS-636
    https://issues.apache.org/jira/browse/MESOS-636


Repository: mesos-git


Description
-------

Also, fixed some warnings related to OffersRescinded in slave recovery tests that were introduced in an earlier submitted review.


Diffs (updated)
-----

  src/slave/cgroups_isolator.cpp 3427c62416daced68f818feb60f194e00a68d94c 
  src/slave/process_isolator.cpp a80b047047ce8bb7193f451cd980a9b268ab6d9e 
  src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8 

Diff: https://reviews.apache.org/r/13449/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request 13449: Fixed cgroups isolator to do setsid on the executor process.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13449/#review24947
-----------------------------------------------------------



src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/13449/#comment49119>

    Should be cgroup isolator? Copy-paste error?


- Jie Yu


On Aug. 9, 2013, 10:05 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13449/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2013, 10:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-636
>     https://issues.apache.org/jira/browse/MESOS-636
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Also, fixed some warnings related to OffersRescinded in slave recovery tests that were introduced in an earlier submitted review.
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolator.cpp 3427c62416daced68f818feb60f194e00a68d94c 
>   src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8 
> 
> Diff: https://reviews.apache.org/r/13449/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>