You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/14 04:33:30 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8660: ARROW-10173: [Rust][DataFusion] Implement support for direct comparison to scalar values

jorgecarleitao commented on a change in pull request #8660:
URL: https://github.com/apache/arrow/pull/8660#discussion_r523374604



##########
File path: rust/datafusion/src/physical_plan/mod.rs
##########
@@ -100,6 +100,30 @@ pub enum Distribution {
     SinglePartition,
 }
 
+/// Represents the result from an expression
+pub enum ColumnarValue {

Review comment:
       I agree.
   
   It would also simplify the API of many vertical operations (e.g. aggregates), as their input and result would have a common type. I have a branch on which I am doing that, but I have not finish it yet.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org