[jira] [Comment Edited] (FLINK-19853) BulkSlotProviderImplTest.testFailedBulkSlotAllocationReleasesAllocatedSlot failed in azure

["Zhu Zhu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-19853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224519#comment-17224519 ] 

Zhu Zhu edited comment on FLINK-19853 at 11/2/20, 9:11 AM:
-----------------------------------------------------------

The failure cause is the concurrency of the released slot check and the slot releasing, because the pending logical slot allocation futures, of which the completion blocks the test thread, will be canceled before releasing the physical slot. So it is a test issue.
One way to fix the test case is to wait for the physical slots to be released within a period instead immediately check it is released.
However, given that {{BulkSlotProviderImpl}} is no longer used after we have {{SlotSharingExecutionSlotAllocator}}. I think we can simply remove it along with its tests.


was (Author: zhuzh):
The failure cause is the concurrency of the released slot check and the slot releasing, because the pending logical slot allocation futures will be canceled before releasing the physical slot. So it is a test issue.
One way to fix the test case is to wait for the physical slots to be released within a period instead immediately check it is released.
However, given that {{BulkSlotProviderImpl}} is no longer used after we have {{SlotSharingExecutionSlotAllocator}}. I think we can simply remove it along with its tests.

> BulkSlotProviderImplTest.testFailedBulkSlotAllocationReleasesAllocatedSlot failed in azure
> ------------------------------------------------------------------------------------------
>
>                 Key: FLINK-19853
>                 URL: https://issues.apache.org/jira/browse/FLINK-19853
>             Project: Flink
>          Issue Type: Test
>          Components: Runtime / Coordination
>    Affects Versions: 1.12.0
>            Reporter: Jingsong Lee
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.12.0
>
>
> Instance: [https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_apis/build/builds/8486/logs/80]
> {code:java}
> 2020-10-28T10:08:41.3922048Z java.lang.AssertionError: 
> 2020-10-28T10:08:41.3923050Z 
> 2020-10-28T10:08:41.3923362Z Expected: a collection with size <0>
> 2020-10-28T10:08:41.3926321Z      but: collection size was <1>
> 2020-10-28T10:08:41.3926732Z 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
> 2020-10-28T10:08:41.3927463Z 	at org.junit.Assert.assertThat(Assert.java:956)
> 2020-10-28T10:08:41.3928006Z 	at org.junit.Assert.assertThat(Assert.java:923)
> 2020-10-28T10:08:41.3928622Z 	at org.apache.flink.runtime.jobmaster.slotpool.BulkSlotProviderImplTest.testFailedBulkSlotAllocationReleasesAllocatedSlot(BulkSlotProviderImplTest.java:154)
> 2020-10-28T10:08:41.3929157Z 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 2020-10-28T10:08:41.3929530Z 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 2020-10-28T10:08:41.3929981Z 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)