[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #493: feat: add valid for plugins

["tao12345666333 (via GitHub)" <gi...@apache.org>]

tao12345666333 commented on code in PR #493:
URL: https://github.com/apache/apisix-helm-chart/pull/493#discussion_r1122661928


##########
charts/apisix/values.yaml:
##########
@@ -399,20 +399,18 @@ customPlugins:
   luaPath: "/opts/custom_plugins/?.lua"
   plugins:
     # -- plugin name.
-    - name: ""
+    - name: "plugin-name"
       # -- plugin attrs
       attrs: {}
       # -- plugin codes can be saved inside configmap object.
       configMap:
         # -- name of configmap.
-        name: ""
+        name: "configmap-name"
         # -- since keys in configmap is flat, mountPath allows to define the mount
         # path, so that plugin codes can be mounted hierarchically.
         mounts:
-          - key: ""
-            path: ""
-          - key: ""
-            path: ""
+          - key: "the-file-name"
+            path: "mount-path"

Review Comment:
   These modifications are made to pass lint,
   They are now not allowed to be empty



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org