[GitHub] [accumulo] ctubbsii commented on a change in pull request #2015: Pom changes to allow reuseForks to be set to true

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2015:
URL: https://github.com/apache/accumulo/pull/2015#discussion_r614456377



##########
File path: pom.xml
##########
@@ -822,6 +822,30 @@
             </systemPropertyVariables>
             <argLine>${unitTestMemSize}</argLine>
           </configuration>
+          <executions>
+            <execution>
+              <id>reuseForks-false-tests</id>
+              <goals>
+                <goal>test</goal>
+              </goals>
+              <configuration>
+                <forkCount>${surefire.forkCount}</forkCount>
+                <reuseForks>false</reuseForks>
+                <includes>
+                  <include>**/TableIdTest.java</include>
+                  <include>**/HadoopCredentialProviderTest.java</include>
+                  <include>**/IdleRatioScanPrioritizerTest.java</include>
+                  <include>**/AssignmentWatcherTest.java</include>
+                  <include>**/TestCfCqSlice.java</include>
+                  <include>**/TestCfCqSliceSeekingFilter.java</include>
+                </includes>
+                <systemPropertyVariables>
+                  <java.io.tmpdir>${project.build.directory}</java.io.tmpdir>
+                </systemPropertyVariables>
+                <argLine>${unitTestMemSize}</argLine>

Review comment:
       This looks like it could work, but there's a few things:
   
   1. I don't think it's necessary to include configuration in this specific execution that is already okay at the level above, directly under the plugin, because it *should* inherit it from there. So, the system properties, forkCount, and argLine can probably be omitted.
   2. Declaring the second execution in the root pom will make it execute for every module, even if there's no files in that module that would match the pattern. This might be okay if it's not too costly. Otherwise, it might be worth placing this in each child pom that has matching files that would be affected.
   3. Need to double check that the second execution doesn't clobber the reports generated by the first execution. Hopefully, it only adds new reports, and doesn't clobber, but I haven't checked.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org